Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: merge attributes without tag and attributes with tag #408

Closed
wants to merge 4 commits into from
Closed

fix: merge attributes without tag and attributes with tag #408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
64fda8d
docs(readme): clarify that tag is not optional if extending default s…
scottohara Oct 27, 2021
687b4f9
docs(readme): add examples for optional tag
scottohara Oct 27, 2021
03a81db
docs(readme): revert earlier changes
scottohara Oct 30, 2021
7536bfc
fix: merge attributes without tag and attributes with tag
scottohara Oct 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/plugins/sources-plugin.js
View file
Open in desktop
Expand Up @@ -41,9 +41,10 @@ export default (options) =>

name = attribute.prefix ? `${attribute.prefix}:${name}` : name;

const handlers =
options.sources.list.get(tagName.toLowerCase()) ||
options.sources.list.get("*");
const handlers = new Map([
...(options.sources.list.get("*") || new Map()),
...(options.sources.list.get(tagName.toLowerCase()) || new Map()),
]);

if (!handlers) {
return;
Expand Down