This repository has been archived by the owner on Aug 20, 2018. It is now read-only.
refactor: apply webpack-defaults #48
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Installation section on readme
making sure source is string before parsing
Fix when multiple
updated installation instructions
Create LICENSE file so GitHub displays its icon
Update README with -loader suffix to reflect Webpack 2 change
docs(README): refactor for webpack v2
Fix maintainer HTML syntax (doc was broken)
michael-ciniawsky
suggested changes
Apr 9, 2017
| .replace(/\u2028/g, '\\u2028') | ||
| .replace(/\u2029/g, '\\u2029'); | ||
| value = options.stringify ? `'${value}'` : value; | ||
| const module = this.version && this.version >= 2 ? `export default ${value};` : `module.exports = ${value};`; |
There was a problem hiding this comment.
webpack 2 has JSON support in core, so better display a warning to about that && remove json-loader from webpack.config.js
if (this.version && this.version < 2)
const module = `module.exports = ${value};`;
return cb(null, module)
}
this.emitWarning(`message`)
return cb(null, value) // not 100% about that :)
|
So given webpack > 2 has native json support, we should probably skip the defaults upgrade and just throw an deprecation warning for 2.x. The defaults upgrade is of no benefit to webpack 1.x. |
|
Yep or that I can do a separate PR with the warning etc |
|
I think we should also check |
joshwiens
force-pushed
the
master
branch
4 times, most recently
from
c64e238
to
3f4f9cf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Intended to be merged & released as a part of
1.0.0on a betadist-tagonce this has been finished and properly tested.BREAKING CHANGE:
Enforces NodeJS > 4.3 via engines
Closes #47