fix: review changes

webpack-contrib · Sep 12, 2018 · 23ea2cb · 23ea2cb
1 parent 8e97331
commit 23ea2cb
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/src/index.js b/src/index.js
@@ -147,7 +147,7 @@ class MiniCssExtractPlugin {
             );
           }
 
-          module.buildInfo = module.buildInfo || { assets: {} };
+          module.buildInfo = module.buildInfo || {};
           module.buildInfo.assets = {
             ...module.buildInfo.assets,
             ...assets,

diff --git a/src/loader.js b/src/loader.js
@@ -76,7 +76,7 @@ export function pitch(request) {
   );
 
   let source;
-  let assets = {};
+  const assets = {};
   childCompiler.hooks.afterCompile.tap(pluginName, (compilation) => {
     source =
       compilation.assets[childFilename] &&
@@ -85,7 +85,7 @@ export function pitch(request) {
     // Collect assets from modules
     compilation.modules.forEach((module) => {
       if (module.buildInfo && module.buildInfo.assets) {
-        assets = { ...assets, ...module.buildInfo.assets };
+        Object.assign(assets, module.buildInfo.assets);
       }
     });