Skip to content

Commit

Permalink
feat: add orderWarnings flag
Browse files Browse the repository at this point in the history
The flag defaults to true, which retains the existing behaviour of
warnings when there is conflicting import order between multiple CSS
files. When set to false, these warnings are not generated.
  • Loading branch information
hedgepigdaniel committed Mar 27, 2019
1 parent 272910c commit 9c1c9b4
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 11 deletions.
3 changes: 2 additions & 1 deletion README.md
Expand Up @@ -50,7 +50,8 @@ module.exports = {
// Options similar to the same options in webpackOptions.output
// both options are optional
filename: "[name].css",
chunkFilename: "[id].css"
chunkFilename: "[id].css",
orderWarning: true // Disable to remove warnings about conflicting order
})
],
module: {
Expand Down
25 changes: 15 additions & 10 deletions src/index.js
Expand Up @@ -113,6 +113,7 @@ class MiniCssExtractPlugin {
this.options = Object.assign(
{
filename: '[name].css',
orderWarning: true,
},
options
);
Expand Down Expand Up @@ -480,16 +481,20 @@ class MiniCssExtractPlugin {
// use list with fewest failed deps
// and emit a warning
const fallbackModule = bestMatch.pop();
compilation.warnings.push(
new Error(
`chunk ${chunk.name || chunk.id} [mini-css-extract-plugin]\n` +
'Conflicting order between:\n' +
` * ${fallbackModule.readableIdentifier(requestShortener)}\n` +
`${bestMatchDeps
.map((m) => ` * ${m.readableIdentifier(requestShortener)}`)
.join('\n')}`
)
);
if (this.options.orderWarning) {
compilation.warnings.push(
new Error(
`chunk ${chunk.name || chunk.id} [mini-css-extract-plugin]\n` +
'Conflicting order between:\n' +
` * ${fallbackModule.readableIdentifier(
requestShortener
)}\n` +
`${bestMatchDeps
.map((m) => ` * ${m.readableIdentifier(requestShortener)}`)
.join('\n')}`
)
);
}
usedModules.add(fallbackModule);
}
}
Expand Down

0 comments on commit 9c1c9b4

Please sign in to comment.