Skip to content

Commit

Permalink
fix: add ChunkLoadError name to chunk loading error (#1073)
Browse files Browse the repository at this point in the history
  • Loading branch information
@alexander-akait
alexander-akait committed Jan 10, 2024
1 parent 60c5331 commit e3f8375
Show file tree
Hide file tree
Showing 11 changed files with 24 additions and 16 deletions.
6 changes: 4 additions & 2 deletions src/index.js
View file
Expand Up @@ -876,9 +876,11 @@ class MiniCssExtractPlugin {
Template.indent(["resolve();"]),
"} else {",
Template.indent([
"var errorType = event && (event.type === 'load' ? 'missing' : event.type);",
"var errorType = event && event.type;",
"var realHref = event && event.target && event.target.href || fullhref;",
'var err = new Error("Loading CSS chunk " + chunkId + " failed.\\n(" + realHref + ")");',
'var err = new Error("Loading CSS chunk " + chunkId + " failed.\\n(" + errorType + ": " + realHref + ")");',
'err.name = "ChunkLoadError";',
// TODO remove `code` in the future major release to align with webpack
'err.code = "CSS_CHUNK_LOAD_FAILED";',
"err.type = errorType;",
"err.request = realHref;",
Expand Down
0 ...5-importModule/0.55be87a9aa9996fc905c.css → ...5-importModule/0.7f0e5fa686a9bb728e64.css
View file
File renamed without changes.
0 ...k-5-importModule/55be87a9aa9996fc905c.css → ...k-5-importModule/7f0e5fa686a9bb728e64.css
View file
File renamed without changes.
7 changes: 4 additions & 3 deletions test/cases/chunkFilename-fullhash/expected/webpack-5-importModule/main.js
View file
Expand Up @@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__);
/******/
/******/ /* webpack/runtime/getFullHash */
/******/ (() => {
/******/ __webpack_require__.h = () => ("55be87a9aa9996fc905c")
/******/ __webpack_require__.h = () => ("7f0e5fa686a9bb728e64")
/******/ })();
/******/
/******/ /* webpack/runtime/global */
Expand Down Expand Up @@ -187,9 +187,10 @@ __webpack_require__.r(__webpack_exports__);
/******/ if (event.type === 'load') {
/******/ resolve();
/******/ } else {
/******/ var errorType = event && (event.type === 'load' ? 'missing' : event.type);
/******/ var errorType = event && event.type;
/******/ var realHref = event && event.target && event.target.href || fullhref;
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + realHref + ")");
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + errorType + ": " + realHref + ")");
/******/ err.name = "ChunkLoadError";
/******/ err.code = "CSS_CHUNK_LOAD_FAILED";
/******/ err.type = errorType;
/******/ err.request = realHref;
Expand Down
0 ...cted/webpack-5/0.4a73d63c8c2357971fc6.css → ...cted/webpack-5/0.100253bb7576627988e6.css
View file
File renamed without changes.
0 ...pected/webpack-5/4a73d63c8c2357971fc6.css → ...pected/webpack-5/100253bb7576627988e6.css
View file
File renamed without changes.
7 changes: 4 additions & 3 deletions test/cases/chunkFilename-fullhash/expected/webpack-5/main.js
View file
Expand Up @@ -73,7 +73,7 @@ __webpack_require__.r(__webpack_exports__);
/******/
/******/ /* webpack/runtime/getFullHash */
/******/ (() => {
/******/ __webpack_require__.h = () => ("4a73d63c8c2357971fc6")
/******/ __webpack_require__.h = () => ("100253bb7576627988e6")
/******/ })();
/******/
/******/ /* webpack/runtime/global */
Expand Down Expand Up @@ -187,9 +187,10 @@ __webpack_require__.r(__webpack_exports__);
/******/ if (event.type === 'load') {
/******/ resolve();
/******/ } else {
/******/ var errorType = event && (event.type === 'load' ? 'missing' : event.type);
/******/ var errorType = event && event.type;
/******/ var realHref = event && event.target && event.target.href || fullhref;
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + realHref + ")");
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + errorType + ": " + realHref + ")");
/******/ err.name = "ChunkLoadError";
/******/ err.code = "CSS_CHUNK_LOAD_FAILED";
/******/ err.type = errorType;
/******/ err.request = realHref;
Expand Down
5 changes: 3 additions & 2 deletions test/cases/hmr/expected/main.js
View file
Expand Up @@ -950,9 +950,10 @@ __webpack_require__.r(__webpack_exports__);
/******/ if (event.type === 'load') {
/******/ resolve();
/******/ } else {
/******/ var errorType = event && (event.type === 'load' ? 'missing' : event.type);
/******/ var errorType = event && event.type;
/******/ var realHref = event && event.target && event.target.href || fullhref;
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + realHref + ")");
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + errorType + ": " + realHref + ")");
/******/ err.name = "ChunkLoadError";
/******/ err.code = "CSS_CHUNK_LOAD_FAILED";
/******/ err.type = errorType;
/******/ err.request = realHref;
Expand Down
5 changes: 3 additions & 2 deletions test/cases/insert-function/expected/main.js
View file
Expand Up @@ -171,9 +171,10 @@
/******/ if (event.type === 'load') {
/******/ resolve();
/******/ } else {
/******/ var errorType = event && (event.type === 'load' ? 'missing' : event.type);
/******/ var errorType = event && event.type;
/******/ var realHref = event && event.target && event.target.href || fullhref;
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + realHref + ")");
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + errorType + ": " + realHref + ")");
/******/ err.name = "ChunkLoadError";
/******/ err.code = "CSS_CHUNK_LOAD_FAILED";
/******/ err.type = errorType;
/******/ err.request = realHref;
Expand Down
5 changes: 3 additions & 2 deletions test/cases/insert-string/expected/main.js
View file
Expand Up @@ -171,9 +171,10 @@
/******/ if (event.type === 'load') {
/******/ resolve();
/******/ } else {
/******/ var errorType = event && (event.type === 'load' ? 'missing' : event.type);
/******/ var errorType = event && event.type;
/******/ var realHref = event && event.target && event.target.href || fullhref;
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + realHref + ")");
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + errorType + ": " + realHref + ")");
/******/ err.name = "ChunkLoadError";
/******/ err.code = "CSS_CHUNK_LOAD_FAILED";
/******/ err.type = errorType;
/******/ err.request = realHref;
Expand Down
5 changes: 3 additions & 2 deletions test/cases/insert-undefined/expected/main.js
View file
Expand Up @@ -171,9 +171,10 @@
/******/ if (event.type === 'load') {
/******/ resolve();
/******/ } else {
/******/ var errorType = event && (event.type === 'load' ? 'missing' : event.type);
/******/ var errorType = event && event.type;
/******/ var realHref = event && event.target && event.target.href || fullhref;
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + realHref + ")");
/******/ var err = new Error("Loading CSS chunk " + chunkId + " failed.\n(" + errorType + ": " + realHref + ")");
/******/ err.name = "ChunkLoadError";
/******/ err.code = "CSS_CHUNK_LOAD_FAILED";
/******/ err.type = errorType;
/******/ err.request = realHref;
Expand Down

0 comments on commit e3f8375

Please sign in to comment.