Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update bug report template #545

Merged
merged 3 commits into from Aug 24, 2021
Merged

docs: update bug report template #545

merged 3 commits into from Aug 24, 2021

Conversation

snitin315
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Aug 24, 2021

Codecov Report

Merging #545 (0ddba10) into master (4899cc5) will increase coverage by 0.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #545      +/-   ##
==========================================
+ Coverage   93.26%   93.58%   +0.32%     
==========================================
  Files           5        5              
  Lines         312      312              
  Branches      101      101              
==========================================
+ Hits          291      292       +1     
+ Misses         19       18       -1     
  Partials        2        2              
Impacted Files Coverage Δ
src/utils.js 90.00% <0.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4899cc5...0ddba10. Read the comment docs.

@alexander-akait
Copy link
Member

/cc @snitin315 I updated more templates and improve them, can you review? If it will be ok, let's update them everywhere

Copy link
Member Author

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few suggestions. I will update templates in other repos.

@@ -3,48 +3,33 @@ name: 🐛 Bug Report
about: Something went awry and you'd like to tell us about it.
---

<!--
Issues are so 🔥
<!-- Please don't delete this template because we'll close your issue -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- Please don't delete this template because we'll close your issue -->
<!-- Please don't delete this template otherwise your issue will be closed immediately -->

👉🏽 Need support, advice, or help? Don't open an issue!
Head to StackOverflow or https://gitter.im/webpack/webpack.
-->
<!-- Please don't delete this template because we'll close your issue -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- Please don't delete this template because we'll close your issue -->
<!-- Please don't delete this template otherwise your issue will be closed immediately -->

- NPM Version:
- webpack Version:
- postcss-loader Version:
<!-- Please don't delete this template because we'll close your issue -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- Please don't delete this template because we'll close your issue -->
<!-- Please don't delete this template otherwise your issue will be closed immediately -->

@@ -3,25 +3,19 @@ name: 🔧 Modification Request
about: Would you like something work differently? Have an alternative approach? This is the template for you.
---

<!--
Issues are so 🔥
<!-- Please don't delete this template because we'll close your issue -->
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<!-- Please don't delete this template because we'll close your issue -->
<!-- Please don't delete this template otherwise your issue will be closed immediately -->

@alexander-akait
Copy link
Member

@snitin315 done 👍

@snitin315
Copy link
Member Author

Good to merge 👍🏻

@alexander-akait alexander-akait merged commit bcf088a into master Aug 24, 2021
@alexander-akait alexander-akait deleted the snitin315-patch-1 branch August 24, 2021 11:07
@alexander-akait
Copy link
Member

@snitin315 oh, we forget one thing, for third party loader/plugins, we should also ask version, for example here is postcss

@alexander-akait
Copy link
Member

@snitin315 I think we should improve our info command, i.e. nxp webpack-cli info --additional-package postcss to show in good format, also we should use webpack-cli instead of webpack to avoiding extra installation

@alexander-akait
Copy link
Member

alexander-akait commented Aug 24, 2021

I will fix it, after merge webpack/webpack-cli#2907 and improve --additional-package, so our command will be fast without extra installation and flexibility

@snitin315
Copy link
Member Author

That will a great enhancement 👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants