Skip to content
This repository has been archived by the owner on Mar 17, 2021. It is now read-only.

fix(index): escape invalid characters #43

Merged
merged 4 commits into from
Nov 17, 2017
Merged

fix(index): escape invalid characters #43

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
78cb753
Handle special whitespace characters.
joeheyming Nov 14, 2017
c53a7de
Address code review.
joeheyming Nov 15, 2017
6f8b707
Rename some variables.
joeheyming Nov 15, 2017
c047cea
Remove cacheable.
joeheyming Nov 16, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
15 changes: 10 additions & 5 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
/*
MIT License http://www.opensource.org/licenses/mit-license.php
Author Tobias Koppers @sokra
MIT License http://www.opensource.org/licenses/mit-license.php
Author Tobias Koppers @sokra
*/
module.exports = function(content) {
this.cacheable && this.cacheable();
this.value = content;
return "module.exports = " + JSON.stringify(content);
this.cacheable && this.cacheable();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't support webpack 1.x. Cachable can be removed at this point

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok

this.value = content;

var stringified = JSON.stringify(content)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

var stringified = ... => content = ... and maybe rename content to json please :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the content is the raw text of the file. It's not json

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, agreed src as argument and var json = JSON.stringify(src) is better :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

.replace(/\u2028/g, '\\u2028')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

indent chained methods with 2 spaces please

json = ...
  .method()

.replace(/\u2029/g, '\\u2029');

return "module.exports = " + stringified;
}