Skip to content

Commit

Permalink
fix: backported disabled auto importing fiber on node >= 16 (#1014)
Browse files Browse the repository at this point in the history
  • Loading branch information
Morgul committed Jan 14, 2022
1 parent 05b848b commit f4234e4
Show file tree
Hide file tree
Showing 13 changed files with 179 additions and 485 deletions.
3 changes: 3 additions & 0 deletions .eslintrc.js
@@ -1,4 +1,7 @@
module.exports = {
root: true,
extends: ["@webpack-contrib/eslint-config-webpack", "prettier"],
parserOptions: {
ecmaVersion: 2020,
},
};
2 changes: 1 addition & 1 deletion .github/workflows/nodejs.yml
Expand Up @@ -55,7 +55,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest, windows-latest, macos-latest]
node-version: [10.x, 12.x, 14.x]
node-version: [10.x, 12.x, 14.x, 16.x]
webpack-version: [4, latest]

runs-on: ${{ matrix.os }}
Expand Down
4 changes: 3 additions & 1 deletion README.md
Expand Up @@ -186,7 +186,9 @@ module.exports = {
Note that when using `sass` (`Dart Sass`), **synchronous compilation is twice as fast as asynchronous compilation** by default, due to the overhead of asynchronous callbacks.
To avoid this overhead, you can use the [fibers](https://www.npmjs.com/package/fibers) package to call asynchronous importers from the synchronous code path.

We automatically inject the [`fibers`](https://github.com/laverdet/node-fibers) package (setup `sassOptions.fiber`) if is possible (i.e. you need install the [`fibers`](https://github.com/laverdet/node-fibers) package).
We automatically inject the [`fibers`](https://github.com/laverdet/node-fibers) package (setup `sassOptions.fiber`) for `Node.js` less v16.0.0 if is possible (i.e. you need install the [`fibers`](https://github.com/laverdet/node-fibers) package).

> Fibers is not compatible with `Node.js` v16.0.0 or later ([see introduction to readme](https://github.com/laverdet/node-fibers)).
**package.json**

Expand Down

0 comments on commit f4234e4

Please sign in to comment.