fix: backported disabled auto importing fiber on node >= 16
#1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Can you accept CLA? |
|
Ah, it was the email on the commit. I believe that should now be associated with my account. |
Original Changes: 4ca004b
Morgul
force-pushed
the
optional-fibers
branch
from
67178d4
to
205e0fd
Compare
|
Turns out I had to just rewrite the author on the commit, and now it seems all good. |
|
Thanks |
|
Released, try |
|
It works perfectly! |
|
For some reason, we can only stick with v8. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original Changes: 4ca004b
This PR contains a:
Motivation / Use-Case
Backported the changes from 4ca004b to the 10.x line, so that projects stuck on Webpack 4 can still use Node v16.
Breaking Changes
Additional Info
There are unit test failures that seem unrelated to these changes, and the unit tests wouldn't run at all for me before them, so I'm unsure how to handle them.
Additionally, I'm not sure if the
v10branch is the correct one, let me know if this needs to be against a different branch.