Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix peer dependencies #746

Merged
merged 1 commit into from Aug 29, 2019
Merged

Fix peer dependencies #746

merged 1 commit into from Aug 29, 2019

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Aug 23, 2019

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

fix peerDeps

Breaking Changes

No

Additional Info

/cc @arcanis is it right way?

Also i still get warning from npm:

npm WARN sass-loader@7.3.1 requires a peer of node-sass@^4.0.0 but none is installed. You must install peer dependencies yourself.

It is bug on npm side? Because i mark this as optional

@alexander-akait alexander-akait changed the base branch from master to next August 23, 2019 18:34
@arcanis
Copy link

arcanis commented Aug 26, 2019

Hey @evilebottnawi! It sounds correct to me indeed 👍

Also i still get warning from npm:

npm WARN sass-loader@7.3.1 requires a peer of node-sass@^4.0.0 but none is installed. You must install peer dependencies yourself.

It is bug on npm side? Because i mark this as optional

Yep, they have a server-side bug, npm/cli#224 (comment)

@alexander-akait
Copy link
Member Author

/cc @arcanis https://github.com/webpack-contrib/sass-loader/blob/next/src/getSassOptions.js#L43

fibers also should be in peerDeep right?

@codecov
Copy link

codecov bot commented Aug 29, 2019

Codecov Report

Merging #746 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next     #746   +/-   ##
=======================================
  Coverage   97.75%   97.75%           
=======================================
  Files          10       10           
  Lines         178      178           
  Branches       63       63           
=======================================
  Hits          174      174           
  Misses          4        4

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96184e1...94c2b45. Read the comment docs.

@arcanis
Copy link

arcanis commented Aug 29, 2019

fibers also should be in peerDeep right?

Sorry! Yes indeed 👍

@alexander-akait alexander-akait merged commit 8fb2b69 into next Aug 29, 2019
@alexander-akait alexander-akait deleted the fix-peerDependencies branch August 29, 2019 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants