Fetch source maps over HTTP #79
Conversation
| @@ -68,6 +69,20 @@ module.exports = function(input, inputMap) { | |||
| function untouched() { | |||
| callback(null, input, inputMap); | |||
| } | |||
| function fetchHttp(source, callback) { | |||
| http.get(source, function (resp) { | |||
There was a problem hiding this comment.
Built-in http.get() is very bare-bones, e.g. doesn't follow redirects. Should probably use some higher-level library.
Also, does this need caching? Or is there already a cache on another layer?
There was a problem hiding this comment.
Built-in
http.get()is very bare-bones, e.g. doesn't follow redirects. Should probably use some higher-level library.
Also, does this need caching? Or is there already a cache on another layer?
I understand. Any considerations about bringing in a new dependency?
There was a problem hiding this comment.
you can use
got
I'll try. Thanks for recommendation.
|
This PR does not handle HTTP redirection. If the original source map to https://github.com/ThoughtWorksInc/Binding.scala/raw/78443c86e5046bd1e13f1504fa9280e668d55eb9/Binding/src/main/scala/com/thoughtworks/binding/Binding.scala, this PR will create a file with the following content: |
|
Close in favor #113, will be implemented for |
I was running into problems with source map URLs pointing to remote https:// resources. Same problem as #77.
This fix seems to solve my problem by fetching the remote source maps for future bundling. Ideally I would prefer source-map-loader to ignore HTTP URLs and pass them verbatim for the browser to fetch remote source maps when needed. However I couldn't figure out how to do that.
Any feedback is welcome!