refactor: Webpack 4.x compatibility #75
Conversation
- Updates code style to Prettier - Updates engines - Updates loader-utils version - Updates peerDependencies - Enforces commit message formatting - Migrates to CircleCI 2.0 BREAKING CHANGE: Drops support for NodeJS 4.x BREAKING CHANGE: Drops support for Webpack 2.x BREAKING CHANGE: `loaderUtils.getOptions()` is not backwards compatible
| function isWarningTag(warningTags, tag) { | ||
| return warningTags.includes(tag.tagName); | ||
| } | ||
| // FIXME: Due to limtation of parser, we need to implement our |
There was a problem hiding this comment.
This loader is also a candidate for posthtml and the current logic implemented as posthtml-plugins instead, once I figured out what's going on here in particular :). The current code is just crazy...
|
@d3viant0ne Happy New Year! Do you have an estimate on when this might be released? |
|
@d3viant0ne @michael-ciniawsky Any chance we could see a release for this this month? |
|
|
||
| validateOptions(schema, options, 'SVGInlineLoader'); | ||
|
|
||
| return `module.exports = ${JSON.stringify( |
|
@mernen @d3viant0ne @michael-ciniawsky Could I get a status update on this? |
|
@bebraw @d3viant0ne @SpaceK33z @TheLarkInn Hi all, I'm not trying to be a pest, but is there anything I can do to help you get this released? Our team would really appreciate it. Thanks! |
|
@d3viant0ne did you abandon this change / project? |
|
😞 |
|
I migrated to https://www.npmjs.com/package/svg-url-loader and it works fine for me. In case anyone else is interested. I removed all dependency to this lib. |
|
@msphn Thanks for the tip. Unfortunately, this loader has a lot of useful features that aren't included in that other loader (classPrefix is really important for me). Fortunately, this still works with Webpack 4 (for me). |
|
Can I help you, to get this PR into production? |
|
Is there any chance this could get pulled at some point? Is there any issue in the code that prevents that? Update would be very welcome in our team. |
|
It is sad that this PR just sits here. Any change it can be integrated in a new release? |
|
Is there someone over at the core Webpack team that can add someone else as a maintain to this repo? Or maybe transfer ownership if it isn't going to be maintained with the rest of Webpack? |
|
@bebraw, @TheLarkInn, @SpaceK33z - Anyone know what happened to @d3viant0ne ? His last contribution was in February? |
|
@will-russell He (amongst some other developers me included) isn't active in the project anymore. |
@bebraw - thank you for the reply! Who was left in charge of the project; do they know this is hanging out there? |
|
@will-russell I think it's up to the current contrib team to maintain. Someone show pick up the PR and merge. CC @evilebottnawi. |
|
In todo |
|
Are there any news on this issue? |
|
🦗🦗🦗 |
|
Also waiting for this |
Codecov Report
@@ Coverage Diff @@
## master #75 +/- ##
=========================================
Coverage ? 45.51%
=========================================
Files ? 5
Lines ? 156
Branches ? 45
=========================================
Hits ? 71
Misses ? 73
Partials ? 12 Continue to review full report at Codecov.
|
Compatibility issues
Commit message body