Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrades acorn and acorn-walk to 7.1.1 in order to avoid the NPM audit warning here: https://www.npmjs.com/advisories/1488.
Tests all pass fine but I am getting these warnings from
npm
if I updateacorn
andacorn-walk
only.acorn-jsx
is relied upon byeslint
.acorn-dynamic-import
is relied upon bywebpack
.For
acorn-jsx
, I wanted to upgradeeslint
but all this does is remove the onenpm WARN
above and replace it with three others, including one fromeslint-config-th0r
and one fromeslint-config-th0r-react
which haven't been updated in a year and rely uponeslint
v5.x.x. It seems out of scope to change these packages upstream.I have not yet attempted to update
webpack
but that also feels excessive here.What is
webpack-bundle-analyzer
's policy on havingnpm WARN
s? Are they fine to have here? If not, do the maintainers have suggestions on how to work around the above warnings?