Skip to content

Commit

Permalink
feat: migrate importField.test.js to jest
Browse files Browse the repository at this point in the history
  • Loading branch information
@snitin315
snitin315 committed May 7, 2023
1 parent 5eef57b commit 74ca29a
Show file tree
Hide file tree
Showing 2 changed files with 56 additions and 48 deletions.
29 changes: 29 additions & 0 deletions test/__snapshots__/importsField.test.js.snap
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,29 @@
// Jest Snapshot v1, https://goo.gl/fbAQLP

exports[`ImportsFieldPlugin should log the correct info 1`] = `
Array [
"resolve '#a/dist/index.js' in '...'",
" using description file: .../package.json (relative path: .)",
" resolve as internal import",
" using imports field: a/dist/index.js",
" Parsed request is a module",
" using description file: .../package.json (relative path: .)",
" resolve as module",
" looking for modules in .../node_modules",
" existing directory .../node_modules/a",
" using description file: .../node_modules/a/package.json (relative path: .)",
" using exports field: ./lib/lib2/index.js",
" using description file: .../node_modules/a/package.json (relative path: ./lib/lib2/index.js)",
" no extension",
" .../node_modules/a/lib/lib2/index.js doesn't exist",
" .js",
" .../node_modules/a/lib/lib2/index.js.js doesn't exist",
" as directory",
" .../node_modules/a/lib/lib2/index.js doesn't exist",
" using exports field: ./lib/index.js",
" using description file: .../node_modules/a/package.json (relative path: ./lib/index.js)",
" no extension",
" existing file: .../node_modules/a/lib/index.js",
" reporting result .../node_modules/a/lib/index.js",
]
`;
75 changes: 27 additions & 48 deletions test/importsField.js → test/importsField.test.js
View file
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
const path = require("path");
const fs = require("fs");
const should = require("should");
const { processImportsField } = require("../lib/util/entrypoints");
const ResolverFactory = require("../lib/ResolverFactory");
const CachedInputFileSystem = require("../lib/CachedInputFileSystem");
Expand Down Expand Up @@ -1161,17 +1160,19 @@ describe("Process imports field", function exportsField() {
testCases.forEach(testCase => {
it(testCase.name, () => {
if (testCase.expect instanceof Error) {
should.throws(() =>
expect(() =>
processImportsField(testCase.suite[0])(
testCase.suite[1],
new Set(testCase.suite[2])
)
);
).toThrowError();
} else {
processImportsField(testCase.suite[0])(
testCase.suite[1],
new Set(testCase.suite[2])
).should.eql(testCase.expect);
expect(
processImportsField(testCase.suite[0])(
testCase.suite[1],
new Set(testCase.suite[2])
)
).toEqual(testCase.expect);
}
});
});
Expand All @@ -1191,7 +1192,7 @@ describe("ImportsFieldPlugin", () => {
resolver.resolve({}, fixture, "#imports-field", {}, (err, result) => {
if (err) return done(err);
if (!result) throw new Error("No result");
result.should.equal(path.resolve(fixture, "b.js"));
expect(result).toEqual(path.resolve(fixture, "b.js"));
done();
});
});
Expand All @@ -1205,7 +1206,7 @@ describe("ImportsFieldPlugin", () => {
(err, result) => {
if (err) return done(err);
if (!result) throw new Error("No result");
result.should.equal(path.resolve(fixture, "b.js"));
expect(result).toEqual(path.resolve(fixture, "b.js"));
done();
}
);
Expand All @@ -1214,8 +1215,8 @@ describe("ImportsFieldPlugin", () => {
it("should disallow resolve out of package scope", done => {
resolver.resolve({}, fixture, "#b", {}, (err, result) => {
if (!err) throw new Error(`expect error, got ${result}`);
err.should.be.instanceof(Error);
err.message.should.match(/Trying to access out of package scope/);
expect(err).toBeInstanceOf(Error);
expect(err.message).toMatch(/Trying to access out of package scope/);
done();
});
});
Expand All @@ -1232,7 +1233,7 @@ describe("ImportsFieldPlugin", () => {
resolver.resolve({}, fixture, "#imports-field", {}, (err, result) => {
if (err) return done(err);
if (!result) throw new Error("No result");
result.should.equal(path.resolve(fixture, "./b.js"));
expect(result).toEqual(path.resolve(fixture, "b.js"));
done();
});
});
Expand All @@ -1249,7 +1250,7 @@ describe("ImportsFieldPlugin", () => {
resolver.resolve({}, fixture, "#b", {}, (err, result) => {
if (err) return done(err);
if (!result) throw new Error("No result");
result.should.equal(path.resolve(fixture, "./a.js"));
expect(result).toEqual(path.resolve(fixture, "a.js"));
done();
});
});
Expand All @@ -1258,7 +1259,7 @@ describe("ImportsFieldPlugin", () => {
resolver.resolve({}, fixture, "#a/dist/main.js", {}, (err, result) => {
if (err) return done(err);
if (!result) throw new Error("No result");
result.should.equal(
expect(result).toEqual(
path.resolve(fixture, "node_modules/a/lib/lib2/main.js")
);
done();
Expand All @@ -1268,8 +1269,8 @@ describe("ImportsFieldPlugin", () => {
it("should resolve package #2", done => {
resolver.resolve({}, fixture, "#a", {}, (err, result) => {
if (!err) throw new Error(`expect error, got ${result}`);
err.should.be.instanceof(Error);
err.message.should.match(/is not imported from package/);
expect(err).toBeInstanceOf(Error);
expect(err.message).toMatch(/is not imported from package/);
done();
});
});
Expand All @@ -1278,7 +1279,7 @@ describe("ImportsFieldPlugin", () => {
resolver.resolve({}, fixture, "#ccc/index.js", {}, (err, result) => {
if (err) return done(err);
if (!result) throw new Error("No result");
result.should.equal(path.resolve(fixture, "node_modules/c/index.js"));
expect(result).toEqual(path.resolve(fixture, "node_modules/c/index.js"));
done();
});
});
Expand All @@ -1287,7 +1288,7 @@ describe("ImportsFieldPlugin", () => {
resolver.resolve({}, fixture, "#c", {}, (err, result) => {
if (err) return done(err);
if (!result) throw new Error("No result");
result.should.equal(path.resolve(fixture, "node_modules/c/index.js"));
expect(result).toEqual(path.resolve(fixture, "node_modules/c/index.js"));
done();
});
});
Expand All @@ -1309,7 +1310,7 @@ describe("ImportsFieldPlugin", () => {
if (err) return done(err);
if (!result) throw new Error("No result");
console.log(result);
result.should.equal(file);
expect(result).toEqual(file);
done();
});
});
Expand All @@ -1325,34 +1326,12 @@ describe("ImportsFieldPlugin", () => {
(err, result) => {
if (err) return done(err);
if (!result) throw new Error("No result");
result.should.be.eql(path.join(fixture, "node_modules/a/lib/index.js"));
log
.map(line => line.replace(fixture, "...").replace(/\\/g, "/"))
.should.be.eql([
"resolve '#a/dist/index.js' in '...'",
" using description file: .../package.json (relative path: .)",
" resolve as internal import",
" using imports field: a/dist/index.js",
" Parsed request is a module",
" using description file: .../package.json (relative path: .)",
" resolve as module",
" looking for modules in .../node_modules",
" existing directory .../node_modules/a",
" using description file: .../node_modules/a/package.json (relative path: .)",
" using exports field: ./lib/lib2/index.js",
" using description file: .../node_modules/a/package.json (relative path: ./lib/lib2/index.js)",
" no extension",
" .../node_modules/a/lib/lib2/index.js doesn't exist",
" .js",
" .../node_modules/a/lib/lib2/index.js.js doesn't exist",
" as directory",
" .../node_modules/a/lib/lib2/index.js doesn't exist",
" using exports field: ./lib/index.js",
" using description file: .../node_modules/a/package.json (relative path: ./lib/index.js)",
" no extension",
" existing file: .../node_modules/a/lib/index.js",
" reporting result .../node_modules/a/lib/index.js"
]);
expect(result).toEqual(
path.join(fixture, "node_modules/a/lib/index.js")
);
expect(
log.map(line => line.replace(fixture, "...").replace(/\\/g, "/"))
).toMatchSnapshot();
done();
}
);
Expand All @@ -1366,7 +1345,7 @@ describe("ImportsFieldPlugin", () => {
resolver.resolve({}, fixture, "#internal/i.js", {}, (err, result) => {
if (err) return done(err);
if (!result) throw new Error("No result");
result.should.equal(path.resolve(fixture, "./src/internal/i.js"));
expect(result).toEqual(path.resolve(fixture, "./src/internal/i.js"));
done();
});
});
Expand Down

0 comments on commit 74ca29a

Please sign in to comment.