Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resolve PnP at the location of node_modules in the modules option #245

Merged
merged 1 commit into from Sep 17, 2020

Conversation

sokra
Copy link
Member

@sokra sokra commented Sep 17, 2020

fallback to other alternatives when PnP reports an undeclared dependency

fixes vercel/next.js#16892

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@codecov
Copy link

codecov bot commented Sep 17, 2020

Codecov Report

Merging #245 into master will decrease coverage by 0.24%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #245      +/-   ##
==========================================
- Coverage   94.84%   94.60%   -0.25%     
==========================================
  Files          39       39              
  Lines        1494     1500       +6     
==========================================
+ Hits         1417     1419       +2     
- Misses         77       81       +4     
Impacted Files Coverage Δ
lib/PnpPlugin.js 82.14% <50.00%> (-13.32%) ⬇️
lib/ResolverFactory.js 96.98% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c200a08...6ec84c2. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Absolute Imports and aliases feature does not work with Webpack 5 + TypeScript + Yarn PnP
2 participants