[draft] feat: resolve style field in package json #388
Conversation
| "existing-directory", | ||
| styleField, | ||
| "resolve-in-existing-directory" |
There was a problem hiding this comment.
todo: check if these are the correct source and target
| return callback(); | ||
| } | ||
| if ( | ||
| // this.options.forceRelative |
There was a problem hiding this comment.
todo: add support for forceRelative
| // @ts-ignore | ||
| request.context.issuer && | ||
| // @ts-ignore | ||
| request.context.issuer.endsWith(".css"); |
There was a problem hiding this comment.
todo: check for all known css extensions
todo2: allow consumer to configure extensions array
| const isIssuerAStyleFile = | ||
| request.context && | ||
| // @ts-ignore | ||
| request.context.issuer && |
There was a problem hiding this comment.
todo: check if type can be improved
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #388 +/- ##
=======================================
Coverage ? 92.88%
=======================================
Files ? 44
Lines ? 2081
Branches ? 615
=======================================
Hits ? 1933
Misses ? 120
Partials ? 28
☔ View full report in Codecov by Sentry. |
|
@burhanuday It should not implemented here, we already support it in css-loader https://github.com/webpack-contrib/css-loader/blob/master/src/plugins/postcss-import-parser.js#L228, we just need to update defaults in webpack |
|
Ah. Will update the defaults in webpack. Did not occur to me that we could just change the default options. Closing this PR |
Part of webpack/webpack#14893