Modify Regex to avoid ReDoS #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportBase: 76.66% // Head: 76.66% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #223 +/- ##
=======================================
Coverage 76.66% 76.66%
=======================================
Files 10 10
Lines 360 360
Branches 112 112
=======================================
Hits 276 276
Misses 73 73
Partials 11 11
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Fixed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #216 (comment), this is offered as a potential fix for the security vulnerability identified in the interpolateName.js method. I used this online ReDoS checker: https://devina.io/redos-checker
The interpolateName.js tests pass with this change, but I'm not familiar enough with the code to be sure this wouldn't introduce problems for some valid inputs.
I'm submitting PRs for all three branches because our projects need versions 2.x and 1.x (loader-utils is a transitive dependency in multiple packages).