Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement undefinedAsNull keyword for enum type #175

Merged
merged 5 commits into from Jun 7, 2023

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Jun 7, 2023

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

part of webpack/webpack#17339

Breaking Changes

No

Additional Info

Only for enum

We need backport it for v3 too
Also we need to implement this for tooling

@codecov
Copy link

codecov bot commented Jun 7, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.04 🎉

Comparison is base (6d5a65f) 97.43% compared to head (7c5a40e) 97.48%.

❗ Current head 7c5a40e differs from pull request most recent head 10443c3. Consider uploading reports for the commit 10443c3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #175      +/-   ##
==========================================
+ Coverage   97.43%   97.48%   +0.04%     
==========================================
  Files           6        7       +1     
  Lines         741      755      +14     
  Branches      318      321       +3     
==========================================
+ Hits          722      736      +14     
  Misses         17       17              
  Partials        2        2              
Impacted Files Coverage Δ
src/ValidationError.js 96.52% <100.00%> (+0.02%) ⬆️
src/keywords/undefinedAsNull.js 100.00% <100.00%> (ø)
src/validate.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait alexander-akait changed the title feat: implement allowUndefined keyword for enum type feat: implement undefinedAsNull keyword for enum type Jun 7, 2023
@alexander-akait alexander-akait merged commit 1265eac into master Jun 7, 2023
17 checks passed
@alexander-akait alexander-akait deleted the feat-allow-undefined-for-enum branch June 7, 2023 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant