Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lazy loading some modules #178

Merged
merged 2 commits into from Jun 13, 2023
Merged

fix: lazy loading some modules #178

merged 2 commits into from Jun 13, 2023

Conversation

alexander-akait
Copy link
Member

This PR contains a:

  • bugfix
  • new feature
  • code refactor
  • test update
  • typo fix
  • metadata update

Motivation / Use-Case

Avoid to load unnecessary things to improve initial load time

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.01 🎉

Comparison is base (3731a59) 97.49% compared to head (b28edb7) 97.51%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   97.49%   97.51%   +0.01%     
==========================================
  Files           7        8       +1     
  Lines         759      764       +5     
  Branches      325      325              
==========================================
+ Hits          740      745       +5     
  Misses         17       17              
  Partials        2        2              
Impacted Files Coverage Δ
src/ValidationError.js 96.54% <100.00%> (+0.01%) ⬆️
src/util/memorize.js 100.00% <100.00%> (ø)
src/validate.js 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@alexander-akait alexander-akait merged commit 3806c65 into master Jun 13, 2023
19 checks passed
@alexander-akait alexander-akait deleted the fix-lazy-loading branch June 13, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant