Merge pull request #792 from webpack/feature/replace-uglify-with-terser

Feature/replace uglify with terser
webpack · Mar 16, 2019 · 05b92af · 05b92af
2 parents 2106e70 + 89e6b74
commit 05b92af
Show file tree

Hide file tree

Showing 5 changed files with 27 additions and 23 deletions.
diff --git a/packages/generators/init-generator.ts b/packages/generators/init-generator.ts
@@ -43,7 +43,7 @@ export default class InitGenerator extends Generator {
 		this.dependencies = [
 			"webpack",
 			"webpack-cli",
-			"uglifyjs-webpack-plugin",
+			"terser-webpack-plugin",
 			"babel-plugin-syntax-dynamic-import",
 		];
 		this.configuration = {
@@ -430,12 +430,12 @@ export default class InitGenerator extends Generator {
 	public installPlugins() {
 		if (this.isProd) {
 			this.dependencies = this.dependencies.filter(
-				(p: string) => p !== "uglifyjs-webpack-plugin",
+				(p: string) => p !== "terser-webpack-plugin",
 			);
 		} else {
 			this.configuration.config.topScope.push(
-				tooltip.uglify(),
-				"const UglifyJSPlugin = require('uglifyjs-webpack-plugin');",
+				tooltip.terser(),
+				"const TerserPlugin = require('terser-webpack-plugin');",
 				"\n",
 			);
 		}

diff --git a/packages/generators/utils/plugins.ts b/packages/generators/utils/plugins.ts
@@ -3,9 +3,9 @@
  * Callable function with the initial plugins
  *
  * @returns {Function} An function that returns an array
- * that consists of the uglify plugin
+ * that consists of terser-webpack-plugin
  */
 
 export default function(_?: void): string[] {
-	return ["new UglifyJSPlugin()"];
+	return ["new TerserPlugin()"];
 }
diff --git a/packages/generators/utils/tooltip.ts b/packages/generators/utils/tooltip.ts
@@ -50,12 +50,12 @@ export default {
  */`;
 	},
 
-	uglify: (_?: void): string => {
+	terser: (_?: void): string => {
 		return `/*
- * We've enabled UglifyJSPlugin for you! This minifies your app
+ * We've enabled TerserPlugin for you! This minifies your app
  * in order to load faster and run less javascript.
  *
- * https://github.com/webpack-contrib/uglifyjs-webpack-plugin
+ * https://github.com/webpack-contrib/terser-webpack-plugin
  *
  */`;
 	},

diff --git a/packages/migrate/uglifyJsPlugin/__tests__/__snapshots__/uglifyJsPlugin.test.ts.snap b/packages/migrate/uglifyJsPlugin/__tests__/__snapshots__/uglifyJsPlugin.test.ts.snap
@@ -10,13 +10,13 @@ exports[`uglifyJsPlugin transforms correctly using "uglifyJsPlugin-0" data 1`] =
 `;
 
 exports[`uglifyJsPlugin transforms correctly using "uglifyJsPlugin-1" data 1`] = `
-"const UglifyJsPlugin  = require('uglifyjs-webpack-plugin');
+"const TerserPlugin = require('terser-webpack-plugin');
 module.exports = {
     devtool: \\"source-map\\",
     optimization: {
         minimize: true,
 
-        minimizer: [new UglifyJsPlugin({
+        minimizer: [new TerserPlugin({
             sourceMap: true,
             compress: {}
         })]
@@ -26,13 +26,13 @@ module.exports = {
 `;
 
 exports[`uglifyJsPlugin transforms correctly using "uglifyJsPlugin-2" data 1`] = `
-"const Uglify  = require('uglifyjs-webpack-plugin');
+"const TerserPlugin = require('terser-webpack-plugin');
 module.exports = {
     devtool: \\"source-map\\",
     optimization: {
         minimize: true,
 
-        minimizer: [new Uglify({
+        minimizer: [new TerserPlugin({
             sourceMap: true,
             compress: {}
         })]
@@ -78,7 +78,7 @@ exports[`uglifyJsPlugin transforms correctly using "uglifyJsPlugin-3" data 1`] =
 `;
 
 exports[`uglifyJsPlugin transforms correctly using "uglifyJsPlugin-4" data 1`] = `
-"const UglifyJsPlugin = require('uglifyjs-webpack-plugin');
+"const TerserPlugin = require('terser-webpack-plugin');
 module.exports = {
     devtool: 'eval',
 
@@ -110,7 +110,7 @@ module.exports = {
     optimization: {
         minimize: true,
 
-        minimizer: [new UglifyJsPlugin({
+        minimizer: [new TerserPlugin({
             sourceMap: true
         })]
     }

diff --git a/packages/migrate/uglifyJsPlugin/uglifyJsPlugin.ts b/packages/migrate/uglifyJsPlugin/uglifyJsPlugin.ts
@@ -15,7 +15,8 @@ import { IJSCodeshift, INode } from "../types/NodePath";
  * and adds `optimization.minimize: true` to config
  *
  * If any configuration is passed to UglifyWebpackPlugin
- * plugin instantiation is moved to `optimization.minimizer`.
+ * UglifyWebpackPlugin is replaced with TerserPlugin
+ * and plugin instantiation is moved to `optimization.minimizer`.
  *
  * @param {Object} j - jscodeshift top-level import
  * @param {Node} ast - jscodeshift ast to transform
@@ -63,17 +64,20 @@ export default function(j: IJSCodeshift, ast: INode): INode {
 			* If user is using UglifyJsPlugin directly from webpack
 			* transformation must:
 			* - remove it
-			* - add require for uglify-webpack-plugin
+			* - add require for terser-webpack-plugin
 			* - add to minimizer
 			*/
-				if (pluginVariableAssignment && pluginVariableAssignment.includes("webpack")) {
-					// create require for uglify-webpack-plugin
+				if (pluginVariableAssignment) {
+					// remove require for uglify-webpack-plugin
+					searchForRequirePlugin.remove();
+
+					// create require for terser-webpack-plugin
 					const pathRequire: INode = getRequire(
 						j,
-						"UglifyJsPlugin",
-						"uglifyjs-webpack-plugin",
+						"TerserPlugin",
+						"terser-webpack-plugin",
 					);
-					// append to source code.
+					// prepend to source code.
 					ast
 						.find(j.Program)
 						.replaceWith((p: INode): INode =>
@@ -84,7 +88,7 @@ export default function(j: IJSCodeshift, ast: INode): INode {
 						"init",
 						j.identifier("minimizer"),
 						j.arrayExpression([
-							j.newExpression(j.identifier("UglifyJsPlugin"), [pluginOptions[0]]),
+							j.newExpression(j.identifier("TerserPlugin"), [pluginOptions[0]]),
 						]),
 					);
 				} else {