test: disable colors on CI by default (#2404)

setupTest.js

@@ -1 +1,7 @@
+/*global jasmine*/
+
 jest.setTimeout(240000);
+
+if (!jasmine.testPath.includes('colors.test.js')) {
+    process.env.NO_COLOR = true;
+}

smoketests/missing-packages/webpack-dev-server.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const path = require('path');
 const execa = require('execa');
 const { renameSync } = require('fs');

smoketests/missing-packages/webpack.test.js

@@ -1,3 +1,5 @@
+'use strict';
+
 const path = require('path');
 const execa = require('execa');
 const { renameSync } = require('fs');

test/analyze/analyze-flag.test.js

@@ -1,6 +1,5 @@
 'use strict';
 
-const stripAnsi = require('strip-ansi');
 const { run, runAndGetWatchProc } = require('../utils/test-utils');
 
 describe('--analyze flag', () => {
@@ -24,7 +23,7 @@ describe('--analyze flag', () => {
 
         expect(exitCode).toBe(0);
         expect(stderr).toBeFalsy();
-        expect(stripAnsi(stdout)).toContain('Webpack Bundle Analyzer saved report to');
-        expect(stripAnsi(stdout).match(/Webpack Bundle Analyzer saved report to/g)).toHaveLength(1);
+        expect(stdout).toContain('Webpack Bundle Analyzer saved report to');
+        expect(stdout.match(/Webpack Bundle Analyzer saved report to/g)).toHaveLength(1);
     });
 });

test/build-errors/errors.test.js

@@ -1,6 +1,5 @@
 'use strict';
 
-const stripAnsi = require('strip-ansi');
 const { run } = require('../utils/test-utils');
 const { readFile } = require('fs');
 const { resolve } = require('path');
@@ -12,7 +11,7 @@ describe('errors', () => {
         expect(exitCode).toBe(1);
         expect(stderr).toBeFalsy();
         expect(stdout).toMatch(/ERROR/);
-        expect(stripAnsi(stdout)).toMatch(/Error: Can't resolve/);
+        expect(stdout).toMatch(/Error: Can't resolve/);
     });
 
     it('should output JSON with the "json" flag', () => {

test/build-warnings/warnings.test.js

@@ -1,6 +1,5 @@
 'use strict';
 
-const stripAnsi = require('strip-ansi');
 const { run } = require('../utils/test-utils');
 const { existsSync, readFile } = require('fs');
 const { resolve } = require('path');
@@ -12,7 +11,7 @@ describe('warnings', () => {
         expect(exitCode).toBe(0);
         expect(stderr).toBeFalsy();
         expect(stdout).toMatch(/WARNING/);
-        expect(stripAnsi(stdout)).toMatch(/Error: Can't resolve/);
+        expect(stdout).toMatch(/Error: Can't resolve/);
     });
 
     it('should output JSON with the "json" flag', () => {

test/build/basic/basic.test.js

@@ -1,6 +1,5 @@
 'use strict';
 
-const stripAnsi = require('strip-ansi');
 const { resolve } = require('path');
 const { run } = require('../../utils/test-utils');
 
@@ -148,12 +147,9 @@ describe('bundle command', () => {
         const configPath = resolve(__dirname, './log.config.js');
 
         expect(exitCode).toBe(0);
-
-        const pureStderr = stripAnsi(stderr);
-
-        expect(pureStderr).toContain('Compiler starting...');
-        expect(pureStderr).toContain(`Compiler is using config: '${configPath}'`);
-        expect(pureStderr).toContain('Compiler finished');
+        expect(stderr).toContain('Compiler starting...');
+        expect(stderr).toContain(`Compiler is using config: '${configPath}'`);
+        expect(stderr).toContain('Compiler finished');
         expect(stdout).toBeTruthy();
     });
 });

test/colors/colors.test.js

@@ -3,7 +3,7 @@
 const { run, isWebpack5 } = require('../utils/test-utils');
 const { resolve } = require('path');
 
-describe('colors related tests', () => {
+describe('colors', () => {
     it('should output by default', () => {
         const { exitCode, stderr, stdout } = run(__dirname, [], { env: { FORCE_COLOR: true } });
 
@@ -46,23 +46,23 @@ describe('colors related tests', () => {
         expect(stdout).toContain(`\u001b[1m\u001b[32m${output}\u001b[39m\u001b[22m`);
     });
 
-    it('should disable colored output with --no-color', () => {
-        const { exitCode, stderr, stdout } = run(__dirname, ['--stats=verbose', '--no-color']);
+    it('should work with the "stats" option and --color flags', () => {
+        const { exitCode, stderr, stdout } = run(__dirname, ['--stats=verbose', '--color']);
 
         expect(exitCode).toBe(0);
         expect(stderr).toBeFalsy();
         const output = isWebpack5 ? 'successfully' : 'main.js';
-        expect(stdout).not.toContain(`\u001b[1m\u001b[32m${output}\u001b[39m\u001b[22m`);
-        expect(stdout).toContain(output);
+        expect(stdout).toContain(`\u001b[1m\u001b[32m${output}\u001b[39m\u001b[22m`);
     });
 
-    it('should work with the "stats" option and --color flags', () => {
-        const { exitCode, stderr, stdout } = run(__dirname, ['--stats=verbose', '--color']);
+    it('should disable colored output with --no-color', () => {
+        const { exitCode, stderr, stdout } = run(__dirname, ['--stats=verbose', '--no-color']);
 
         expect(exitCode).toBe(0);
         expect(stderr).toBeFalsy();
         const output = isWebpack5 ? 'successfully' : 'main.js';
-        expect(stdout).toContain(`\u001b[1m\u001b[32m${output}\u001b[39m\u001b[22m`);
+        expect(stdout).not.toContain(`\u001b[1m\u001b[32m${output}\u001b[39m\u001b[22m`);
+        expect(stdout).toContain(output);
     });
 
     it('should work with the "stats" option from the configuration', () => {
@@ -120,7 +120,7 @@ describe('colors related tests', () => {
         expect(stdout).toContain(`\u001b[1m\u001b[32m${output}\u001b[39m\u001b[22m`);
     });
 
-    it('should prioratize --no-color over colors in config', () => {
+    it('should prioritize --no-color over colors in config', () => {
         const { exitCode, stderr, stdout } = run(__dirname, ['--config=colors-true.webpack.config.js', '--no-color']);
 
         expect(exitCode).toBe(0);

test/config/multiple/multiple-config.test.js

@@ -1,16 +1,16 @@
-const stripAnsi = require('strip-ansi');
+'use strict';
 
 const { run } = require('../../utils/test-utils');
 
 describe('Multiple config flag: ', () => {
     it('spawns multiple compilers for multiple configs', () => {
-        const { exitCode, stderr, stdout } = run(__dirname, ['-c', 'webpack1.config.js', '-c', 'webpack2.config.js'], false);
+        const { exitCode, stderr, stdout } = run(__dirname, ['--config', 'webpack1.config.js', '--config', 'webpack2.config.js'], false);
 
         // Should contain the correct exit code
         expect(exitCode).toEqual(0);
         expect(stderr).toBeFalsy();
         // Should spawn multiple compilers
-        expect(stripAnsi(stdout)).toContain('amd:');
-        expect(stripAnsi(stdout)).toContain('commonjs:');
+        expect(stdout).toContain('amd:');
+        expect(stdout).toContain('commonjs:');
     });
 });

test/core-flags/context-flag.test.js

@@ -1,6 +1,5 @@
 'use strict';
 
-const stripAnsi = require('strip-ansi');
 const { resolve } = require('path');
 const { run, isWindows } = require('../utils/test-utils');
 
@@ -24,6 +23,6 @@ describe('--context flag', () => {
 
         expect(exitCode).toBe(1);
         expect(stderr).toBeFalsy();
-        expect(stripAnsi(stdout)).toContain(`Module not found: Error: Can't resolve './src/main.js'`);
+        expect(stdout).toContain(`Module not found: Error: Can't resolve './src/main.js'`);
     });
 });

test/defaults/output-defaults.test.js

@@ -1,6 +1,5 @@
 'use strict';
 
-const stripAnsi = require('strip-ansi');
 const { existsSync } = require('fs');
 const { resolve } = require('path');
 const { run } = require('../utils/test-utils');
@@ -12,7 +11,7 @@ describe('output flag defaults', () => {
         expect(exitCode).toBe(0);
         expect(stderr).toBeFalsy();
         // Should print warning about config fallback
-        expect(stripAnsi(stdout)).toContain('option has not been set, webpack will fallback to');
+        expect(stdout).toContain('option has not been set, webpack will fallback to');
 
         expect(existsSync(resolve(__dirname, './binary/main.js'))).toBeTruthy();
     });

test/entry/defaults-empty/entry-single-arg.test.js

@@ -1,6 +1,5 @@
 'use strict';
 
-const stripAnsi = require('strip-ansi');
 const { run } = require('../../utils/test-utils');
 
 describe('single entry flag empty project', () => {
@@ -9,6 +8,6 @@ describe('single entry flag empty project', () => {
 
         expect(exitCode).toBe(1);
         expect(stderr).toBeFalsy();
-        expect(stripAnsi(stdout)).toContain(`not found: Error: Can't resolve`);
+        expect(stdout).toContain(`not found: Error: Can't resolve`);
     });
 });

test/entry/flag-entry/entry-with-flag.test.js

@@ -1,6 +1,5 @@
 'use strict';
 
-const stripAnsi = require('strip-ansi');
 const { run } = require('../../utils/test-utils');
 const { existsSync, readFile } = require('fs');
 const { resolve } = require('path');
@@ -40,6 +39,6 @@ describe('entry flag', () => {
 
         expect(exitCode).toEqual(1);
         expect(stderr).toBeFalsy();
-        expect(stripAnsi(stdout)).toContain("Module not found: Error: Can't resolve");
+        expect(stdout).toContain("Module not found: Error: Can't resolve");
     });
 });