Skip to content

Commit

Permalink
Merge pull request #910 from anikethsaha/bugfix/native-plugin-add-com…
Browse files Browse the repository at this point in the history
…mand

fix(generator): fixed the support of native plugins in add command
  • Loading branch information
evenstensberg committed Jun 4, 2019
2 parents 103fad1 + c01a80b commit 71a58b6
Showing 1 changed file with 10 additions and 3 deletions.
13 changes: 10 additions & 3 deletions packages/generators/add-generator.ts
Expand Up @@ -291,6 +291,14 @@ export default class AddGenerator extends Generator {
* find the names of each natively plugin and check if it matches
*/
if (action === "plugins") {
let answeredPluginName = answerToAction.actionAnswer;
let isPrefixPresent = /webpack./.test(answeredPluginName);

if (isPrefixPresent) {
answeredPluginName = answeredPluginName.replace("webpack.", "").trim();
} else {
answeredPluginName = answeredPluginName.trim();
}
const pluginExist: string = glob
.sync(["node_modules/webpack/lib/*Plugin.js", "node_modules/webpack/lib/**/*Plugin.js"])
.map(
Expand All @@ -300,7 +308,7 @@ export default class AddGenerator extends Generator {
.pop()
.replace(".js", "")
)
.find((p: string): boolean => p.toLowerCase().indexOf(answerToAction.actionAnswer) >= 0);
.find((p: string): boolean => p.toLowerCase().indexOf(answeredPluginName) >= 0);

if (pluginExist) {
this.configuration.config.item = pluginExist;
Expand All @@ -315,8 +323,7 @@ export default class AddGenerator extends Generator {
.split("/")
.pop()
.replace(".json", "")
.toLowerCase()
.indexOf(answerToAction.actionAnswer) >= 0
.indexOf(answeredPluginName) >= 0
);
if (pluginsSchemaPath) {
const constructorPrefix: string =
Expand Down

0 comments on commit 71a58b6

Please sign in to comment.