fix: avoid unnecessary stringify

webpack · Oct 11, 2020 · eedce42 · eedce42
1 parent d32aeda
commit eedce42
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/packages/webpack-cli/lib/utils/Compiler.js b/packages/webpack-cli/lib/utils/Compiler.js
@@ -78,25 +78,29 @@ class Compiler {
             process.exitCode = 1;
         }
         if (outputOptions.json === true) {
-            process.stdout.write(JSON.stringify(stats.toJson(outputOptions), null, 2) + '\n');
+            process.stdout.write(stats.toJson(outputOptions) + '\n');
         } else if (stats.hash !== lastHash) {
             lastHash = stats.hash;
+
             if (stats.compilation && stats.compilation.errors.length !== 0) {
                 const errors = stats.compilation.errors;
                 errors.forEach((statErr) => {
                     const errLoc = statErr.module ? statErr.module.resource : null;
                     statsErrors.push({ name: statErr.message, loc: errLoc });
                 });
             }
-            const JSONStats = JSON.stringify(stats.toJson(outputOptions), null, 2);
+
             if (typeof outputOptions.json === 'string') {
+                const JSONStats = stats.toJson(outputOptions);
+
                 try {
                     writeFileSync(outputOptions.json, JSONStats);
                     logger.success(`stats are successfully stored as json to ${outputOptions.json}`);
                 } catch (err) {
                     logger.error(err);
                 }
             }
+
             return this.generateOutput(outputOptions, stats, statsErrors);
         }
     }