Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display used config path when logging level=log #2431

Merged
merged 12 commits into from Feb 11, 2021

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?

feat

Did you add tests for your changes?
yes

If relevant, did you update the documentation?
NA

Summary

  • Displays the used config when infra logging level is log, helpful to know which config is in use when there are multiple

Does this PR introduce a breaking change?
No

Other information

@alexander-akait
Copy link
Member

/cc @webpack/cli-team

@codecov
Copy link

codecov bot commented Feb 10, 2021

Codecov Report

Merging #2431 (6cd8ac5) into master (f5c9b6b) will increase coverage by 0.10%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2431      +/-   ##
==========================================
+ Coverage   71.75%   71.86%   +0.10%     
==========================================
  Files          46       46              
  Lines        2174     2182       +8     
  Branches      573      581       +8     
==========================================
+ Hits         1560     1568       +8     
  Misses        614      614              
Impacted Files Coverage Δ
packages/webpack-cli/lib/webpack-cli.js 91.92% <ø> (ø)
packages/webpack-cli/lib/plugins/CLIPlugin.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f5c9b6b...6cd8ac5. Read the comment docs.

snitin315
snitin315 previously approved these changes Feb 10, 2021
@alexander-akait
Copy link
Member

alexander-akait commented Feb 11, 2021

Again problems with cache, we should be careful when setup cache for CI, latest commits for improve it break CI for webpack-cli and webpack-dev-server

@alexander-akait alexander-akait merged commit f8406e1 into master Feb 11, 2021
@alexander-akait alexander-akait deleted the feat/config-path branch February 11, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants