Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display used config path when logging level=log #2397

Closed
wants to merge 4 commits into from

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?

feat

Did you add tests for your changes?
yes

If relevant, did you update the documentation?
NA

Summary

  • Displays the used config when infra logging level is log, helpful to know which config is in use when there are multiple

Does this PR introduce a breaking change?
No

Other information

@anshumanv anshumanv requested a review from a team as a code owner February 2, 2021 06:13
@alexander-akait
Copy link
Member

@anshumanv can you rebase and fix the problem

@alexander-akait
Copy link
Member

We should run message on watch and serve too

@anshumanv
Copy link
Member Author

yep lets do it, more issues with test will fix them today

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #2397 (72f8777) into master (b8deb52) will decrease coverage by 3.28%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2397      +/-   ##
==========================================
- Coverage   71.75%   68.47%   -3.29%     
==========================================
  Files          46       46              
  Lines        2174     2179       +5     
  Branches      573      575       +2     
==========================================
- Hits         1560     1492      -68     
- Misses        614      687      +73     
Impacted Files Coverage Δ
packages/webpack-cli/lib/webpack-cli.js 83.37% <ø> (-8.56%) ⬇️
packages/webpack-cli/lib/plugins/CLIPlugin.js 100.00% <100.00%> (ø)
packages/generators/src/utils/prop-types.ts 80.00% <0.00%> (-20.00%) ⬇️
packages/serve/src/startDevServer.ts 82.25% <0.00%> (-1.62%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8deb52...b75081e. Read the comment docs.

@alexander-akait
Copy link
Member

Please rebase fork

@anshumanv anshumanv reopened this Feb 9, 2021
@anshumanv
Copy link
Member Author

Closing - #2431

@anshumanv anshumanv closed this Feb 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants