Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error message #2482

Merged
merged 4 commits into from Mar 9, 2021
Merged

fix: improve error message #2482

merged 4 commits into from Mar 9, 2021

Conversation

snitin315
Copy link
Member

What kind of change does this PR introduce?
bugfix

Did you add tests for your changes?
WIP on tests
If relevant, did you update the documentation?
No
Summary

Fixes #2479

Does this PR introduce a breaking change?
No

Other information
No

@codecov
Copy link

codecov bot commented Mar 4, 2021

Codecov Report

Merging #2482 (203064b) into master (7398e0c) will increase coverage by 0.05%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2482      +/-   ##
==========================================
+ Coverage   71.86%   71.91%   +0.05%     
==========================================
  Files          46       46              
  Lines        2182     2186       +4     
  Branches      581      583       +2     
==========================================
+ Hits         1568     1572       +4     
  Misses        614      614              
Impacted Files Coverage Δ
packages/webpack-cli/lib/webpack-cli.js 91.84% <83.33%> (-0.09%) ⬇️
packages/webpack-cli/bin/cli.js 55.00% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7398e0c...203064b. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add test?

@snitin315
Copy link
Member Author

Hard to test 😞, WIP.

@rishabh3112
Copy link
Member

rishabh3112 commented Mar 9, 2021

Hard to test, WIP.

Should be a simple smoketest, I am testing now and will send commits to this PR.

@rishabh3112
Copy link
Member

Hard to test, WIP.

Should be a simple smoketest, I am testing now and will send commits to this PR.

Done.

@snitin315
Copy link
Member Author

Should be a simple smoketest, I am testing now and will send commits to this PR.

Done.

Thanks 🚀

@snitin315 snitin315 marked this pull request as ready for review March 9, 2021 10:07
@snitin315 snitin315 requested a review from a team as a code owner March 9, 2021 10:07
@alexander-akait
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Help on certain commands are not available
4 participants