Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add smoketests for missing subpackages #2493

Closed
rishabh3112 opened this issue Mar 9, 2021 · 4 comments
Closed

test: add smoketests for missing subpackages #2493

rishabh3112 opened this issue Mar 9, 2021 · 4 comments
Assignees
@rishabh3112
Labels
Tests

Comments

@rishabh3112
Copy link
Member

Is your feature request related to a problem? Please describe.
Currently we are not testing behaviour when sub packages are missing. I added one in #2482 and I think should be added for other packages.

Describe the solution you'd like
Same as mentioned above.

Describe alternatives you've considered
N/A

Additional context
N/A
@rishabh3112 rishabh3112 self-assigned this Mar 9, 2021
@alexander-akait
Copy link
Member

Yes, PR welcome

This was referenced Mar 11, 2021
Merged
Merged
Merged
Closed
Merged
@jamesgeorge007 jamesgeorge007 mentioned this issue Mar 19, 2021
Merged
@snitin315
Copy link
Member

I'm writing one for missing webpack-bundle-analyzer.

@snitin315 snitin315 mentioned this issue Mar 20, 2021
Merged
@alexander-akait
Copy link
Member

@rishabh3112 What tests do we need more?

@rishabh3112
Copy link
Member Author

We are done, all optional deps are covered now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rishabh3112 rishabh3112

Labels
Tests
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexander-akait @rishabh3112 @snitin315