Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add env var to skip local import #2546

Merged
merged 2 commits into from Mar 24, 2021
Merged

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?
feat

Did you add tests for your changes?
Yes

Summary

Add env var to skip import-local

Does this PR introduce a breaking change?
No

Other information
Fix #2543

@anshumanv anshumanv requested a review from a team as a code owner March 23, 2021 13:43
const { exitCode, stderr, stdout } = run(__dirname, [], {
env: { WEBPACK_CLI_SKIP_IMPORT_LOCAL: true },
});
console.log({ exitCode, stderr, stdout });
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove it

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hm done

@alexander-akait
Copy link
Member

After merge we need improve docs

@anshumanv
Copy link
Member Author

will improve

@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #2546 (d4e6b69) into master (5a3d3e2) will decrease coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2546      +/-   ##
==========================================
- Coverage   90.82%   90.74%   -0.08%     
==========================================
  Files          29       29              
  Lines        1449     1459      +10     
  Branches      411      416       +5     
==========================================
+ Hits         1316     1324       +8     
- Misses        133      135       +2     
Impacted Files Coverage Δ
packages/webpack-cli/bin/cli.js 52.38% <66.66%> (+2.38%) ⬆️
packages/webpack-cli/lib/webpack-cli.js 92.41% <0.00%> (-0.21%) ⬇️
packages/info/src/index.ts 100.00% <0.00%> (ø)
packages/generators/src/types/index.ts 100.00% <0.00%> (ø)
packages/generators/src/handlers/default.ts 94.73% <0.00%> (+0.61%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5a3d3e2...d4e6b69. Read the comment docs.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @webpack/cli-team

@anshumanv anshumanv merged commit e130822 into master Mar 24, 2021
@anshumanv anshumanv deleted the feat/skip-importlocal branch March 24, 2021 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

importLocal check may invoke wrong version of WDS in a Yarn workspace
4 participants