Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: add env var doc #4773

Merged
merged 2 commits into from Mar 28, 2021
Merged

cli: add env var doc #4773

merged 2 commits into from Mar 28, 2021

Conversation

anshumanv
Copy link
Member

@anshumanv anshumanv commented Mar 25, 2021

Added and env var to disable local import

webpack/webpack-cli#2546

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: Stale Pull Requests.

@vercel
Copy link

vercel bot commented Mar 25, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/6xwwo6sLiF7SwEYTR3PrK9PvXG1M
✅ Preview: https://webpack-js-org-git-fork-anshumanv-cli-import-webpack-docs.vercel.app

@anshumanv
Copy link
Member Author

This doesn't really come in config env so I'm skeptical about keeping it here

@chenxsan
Copy link
Member

Or we can add a third column in the table indicating whether the item is available in the env.

@snitin315
Copy link
Member

Or we can add a third column in the table indicating whether the item is available in the env.

Sounds good to me.

@anshumanv
Copy link
Member Author

yeah that makes sense, will update

@snitin315
Copy link
Member

@anshumanv can you also add WEBPACK_PACKAGE while you are at it? webpack/webpack-cli#2556

@anshumanv
Copy link
Member Author

yep lets do it

@anshumanv anshumanv changed the title cli: add import local skip env doc cli: add env var doc Mar 25, 2021
@chenxsan
Copy link
Member

Will merge it when a new version webpack-cli is out.

@anshumanv
Copy link
Member Author

lets merge

@chenxsan chenxsan merged commit 63ce3fe into webpack:master Mar 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants