Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to run commands not requiring webpack without webpack installation #2907

Merged

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Aug 20, 2021

What kind of change does this PR introduce?

feature

Did you add tests for your changes?

Yes, some tests

If relevant, did you update the documentation?

No need

Summary

Allow to run npx webpack-cli info without webpack installation

Does this PR introduce a breaking change?

No

Other information

due v8-compile-cache has bug with import(), after this refactor webpack can use import() to load ECMA modules, it is great fix

@alexander-akait alexander-akait requested a review from a team as a code owner August 20, 2021 18:06
@alexander-akait alexander-akait changed the title feat: allow to run commands not requiring webpack without webpack ins… feat: allow to run commands not requiring webpack without webpack installation Aug 20, 2021
@codecov
Copy link

codecov bot commented Aug 21, 2021

Codecov Report

Merging #2907 (5d7c085) into master (b1a6663) will increase coverage by 0.25%.
The diff coverage is 85.48%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2907      +/-   ##
==========================================
+ Coverage   94.85%   95.11%   +0.25%     
==========================================
  Files          31       31              
  Lines        1673     1679       +6     
  Branches      468      480      +12     
==========================================
+ Hits         1587     1597      +10     
+ Misses         86       82       -4     
Impacted Files Coverage Δ
packages/serve/src/index.ts 84.27% <81.25%> (+0.20%) ⬆️
packages/webpack-cli/lib/webpack-cli.js 96.52% <83.87%> (-0.16%) ⬇️
packages/configtest/src/index.ts 96.29% <88.88%> (+0.14%) ⬆️
packages/generators/src/index.ts 100.00% <100.00%> (ø)
packages/info/src/index.ts 100.00% <100.00%> (ø)
packages/webpack-cli/bin/cli.js 90.00% <100.00%> (+23.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1a6663...5d7c085. Read the comment docs.

@alexander-akait alexander-akait force-pushed the feat-allow-to-run-commands-without-webpack-instalaltion branch from 2186874 to 41868ba Compare August 24, 2021 11:33
@@ -1,27 +1,27 @@
import { devServerOptionsType } from "./types";

const WEBPACK_PACKAGE = process.env.WEBPACK_PACKAGE || "webpack";
const WEBPACK_DEV_SERVER_PACKAGE = process.env.WEBPACK_DEV_SERVER_PACKAGE || "webpack-dev-server";
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snitin315 We should document WEBPACK_DEV_SERVER_PACKAGE after merge this

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will take care of it 👍🏻

@alexander-akait alexander-akait merged commit 603041d into master Aug 25, 2021
@alexander-akait alexander-akait deleted the feat-allow-to-run-commands-without-webpack-instalaltion branch August 25, 2021 14:15
@gribnoysup
Copy link

Any plans on releasing this change in the near future?

@alexander-akait
Copy link
Member Author

Yes, in near future, need to fix the one problem on webpack side

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants