Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: simplify logic, reduce extra loops and perf #3767

Merged
merged 18 commits into from May 7, 2023

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented May 3, 2023

What kind of change does this PR introduce?

Avoid validation of our arguments from command line, i.e. when you have webpack --stats invalid

Did you add tests for your changes?

Update existing

If relevant, did you update the documentation?

No need

Summary

Webpack always validates provided configurations, when we have webpack --stats invalid, we just set stats to "invalid" value and now try to validate it, but I don't see any reasons to spend time on it, because when we pass it to webpack it will be validated again, so now we skip a one extra validation

We can't do it

Does this PR introduce a breaking change?

No

Other information

fixes #2626

@alexander-akait alexander-akait requested a review from a team as a code owner May 3, 2023 20:36
@alexander-akait alexander-akait changed the title Perf reduce loops perf: simplify logic, reduce extra loops and perf May 3, 2023
@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Merging #3767 (c682af9) into master (7235664) will decrease coverage by 0.02%.
The diff coverage is 96.36%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3767      +/-   ##
==========================================
- Coverage   91.64%   91.62%   -0.02%     
==========================================
  Files          22       22              
  Lines        1627     1624       -3     
  Branches      460      463       +3     
==========================================
- Hits         1491     1488       -3     
  Misses        136      136              
Impacted Files Coverage Δ
packages/serve/src/index.ts 79.46% <0.00%> (ø)
packages/webpack-cli/src/webpack-cli.ts 93.02% <98.14%> (-0.02%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7235664...c682af9. Read the comment docs.

ghost referenced this pull request May 4, 2023
@alexander-akait alexander-akait merged commit 6afe1d3 into master May 7, 2023
54 of 55 checks passed
@alexander-akait alexander-akait deleted the perf-reduce-loops branch May 7, 2023 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants