Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: simplify logic, reduce extra loops and perf #3767

Merged
merged 18 commits into from
May 7, 2023
Merged

perf: simplify logic, reduce extra loops and perf #3767

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
1181dd1
perf: do not validate empty options
alexander-akait May 3, 2023
5fa9549
perf: avoid extra validation
alexander-akait May 3, 2023
2d606f4
revert: logic
alexander-akait May 3, 2023
f711635
fix(perf): reduce extra loop
alexander-akait May 3, 2023
1ac26d6
fix: avoid extra `filter` and make the same errors as in configuration
alexander-akait May 3, 2023
3c08278
perf: small optimization
alexander-akait May 3, 2023
cec07cb
perf: small optimization
alexander-akait May 4, 2023
fcd931a
perf: small optimization
alexander-akait May 4, 2023
c2e7bb2
perf: small optimization
alexander-akait May 4, 2023
7ad9416
perf: small optimization
alexander-akait May 4, 2023
6ca8241
test: fix
alexander-akait May 4, 2023
260ca52
test: fix
alexander-akait May 4, 2023
66a64af
test: fix
alexander-akait May 4, 2023
73782bc
refactor: simplify type
alexander-akait May 4, 2023
fd78b07
test: fix
alexander-akait May 4, 2023
7805f2a
test: fix
alexander-akait May 4, 2023
33bb41a
test: update
alexander-akait May 7, 2023
c682af9
test: fix
alexander-akait May 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/serve/src/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@
for (const path in problemsByPath) {
const problems = problemsByPath[path];

problems.forEach((problem: Problem) => {
for (const problem of problems) {

Check warning on line 196 in packages/serve/src/index.ts

View check run for this annotation

Codecov / codecov/patch

packages/serve/src/index.ts#L196 

Added line #L196 was not covered by tests
cli.logger.error(
`${cli.capitalizeFirstLetter(problem.type.replace(/-/g, " "))}${
problem.value ? ` '${problem.value}'` : ""
Expand All @@ -205,7 +205,7 @@
if (problem.expected) {
cli.logger.error(`Expected: '${problem.expected}'`);
}
});
}
}

process.exit(2);
Expand Down
8 changes: 1 addition & 7 deletions packages/webpack-cli/src/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,6 @@ interface WebpackCLIConfig {
interface WebpackCLICommand extends Command {
pkg: string | undefined;
forHelp: boolean | undefined;
options: WebpackCLICommandOption[];
_args: WebpackCLICommandOption[];
}

Expand Down Expand Up @@ -187,10 +186,7 @@ type Callback<T extends unknown[]> = (...args: T) => void;
/**
* Webpack
*/
type WebpackConfiguration = Configuration & {
// TODO add extends to webpack types
extends?: string | string[];
};
type WebpackConfiguration = Configuration;
type ConfigOptions = PotentialPromise<WebpackConfiguration | CallableOption>;
type CallableOption = (env: Env | undefined, argv: Argv) => WebpackConfiguration;
type WebpackCompiler = Compiler | MultiCompiler;
Expand All @@ -209,7 +205,6 @@ type FileSystemCacheOptions = WebpackConfiguration & {

type ProcessedArguments = Record<string, BasicPrimitive | RegExp | (BasicPrimitive | RegExp)[]>;

type MultipleCompilerStatsOptions = StatsOptions & { children: StatsOptions[] };
type CommandAction = Parameters<WebpackCLICommand["action"]>[0];

interface WebpackRunOptions extends WebpackOptionsNormalized {
Expand Down Expand Up @@ -339,7 +334,6 @@ export {
Instantiable,
JsonExt,
ModuleName,
MultipleCompilerStatsOptions,
PackageInstallOptions,
PackageManager,
Path,
Expand Down