New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix jscodeshift import (fixes #1064) #1088
Conversation
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
1 similar comment
There were the following issues with this Pull Request
You may need to change the commit messages to comply with the repository contributing guidelines. 🤖 This comment was generated by commitlint[bot]. Please report issues here. Happy coding! |
Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just one thing! Did you make any changes with dependencies in your local setup or maybe version changes?
Not sure why those changes in the lock file came from!
Well that's odd, I pushed this by mistake :( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm thank you so much for your PR, and congratulations with your first one! 💙 This leads to a new error, can't Cannot read property 'push' of undefined
at findPluginsByName.forEach (/webpack-cli/packages/migrate/uglifyJsPlugin/uglifyJsPlugin.js:68:41)
. Are you willing to fix this as well?
Open an issue using the example file provided in #1064, explain the issue and submit a PR afterwards!
Thank you so much ❤️
Glad to help :) |
Great, thank yous! |
What kind of change does this PR introduce?
Fixes #1064
Did you add tests for your changes?
no :(
This requires testing the CLI itself (as the issue is in index.ts), and currently there are no such tests. I saw there are other CLI tests (for other commands), but none of them test a command which expects user input.
I found the inquirer-test package which might be helpful, so let me know how you think I should proceed here.
Summary
jscodeshift doesn't expose a default import, changed it to import the exported function correctly.
Does this PR introduce a breaking change?
no