Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update generator deps #1758

Closed
wants to merge 3 commits into from
Closed

Conversation

rishabh3112
Copy link
Member

What kind of change does this PR introduce?
chore, avoid duplication of package utils (Just for release)

Did you add tests for your changes?
N/A
If relevant, did you update the documentation?

Summary
Before:
image

After:
image

Does this PR introduce a breaking change?
No

Other information
Not an intended solution. Follow #1752 for it.

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is break yarn PnP

@rishabh3112
Copy link
Member Author

Would adding @webpack-cli/package-utilspackage as a peer dependency solve this?

@alexander-akait
Copy link
Member

I think we can solve it using steps:

  1. Union package-utils and utils into utils
  2. Move out utils for generators into generators package
  3. Additional step - move utils into webpack-cli, because we use almost of them in webpack-cli

@rishabh3112
Copy link
Member Author

rishabh3112 commented Aug 19, 2020

Additional step - move utils into webpack-cli, because we use almost of them in webpack-cli

we don't, we just use package-utils in CLI.
Refer here:

@alexander-akait
Copy link
Member

I mean this packages unnecessary, because we always install then, no need to keep them in deps

@rishabh3112
Copy link
Member Author

rishabh3112 commented Aug 19, 2020

Yes, these packages are unnecessary. As this would take long time to refactor it, I thought of doing this so that we can release within this week. Rest, I also support removing these packages.

@rishabh3112
Copy link
Member Author

Closing as full refactor is in progress at #1822

@rishabh3112 rishabh3112 deleted the chore/rm-package-utils-dep branch September 24, 2020 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants