Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: export utils from core for other packages #2011

Merged
merged 5 commits into from Nov 2, 2020
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/generate-loader/src/index.ts
@@ -1,6 +1,6 @@
import { loaderGenerator } from '@webpack-cli/generators';
import yeoman from 'yeoman-environment';
import logger from 'webpack-cli/lib/utils/logger';
import { logger } from 'webpack-cli';

/**
* Runs a yeoman generator to create a new webpack loader project
Expand Down
2 changes: 1 addition & 1 deletion packages/generate-plugin/src/index.ts
@@ -1,6 +1,6 @@
import { pluginGenerator } from '@webpack-cli/generators';
import yeoman from 'yeoman-environment';
import logger from 'webpack-cli/lib/utils/logger';
import { logger } from 'webpack-cli';

/**
* Runs a yeoman generator to create a new webpack plugin project
Expand Down
2 changes: 1 addition & 1 deletion packages/generators/__tests__/addon-generator.test.ts
Expand Up @@ -5,7 +5,7 @@ jest.setMock('@webpack-cli/utils', {
import fs from 'fs';
import path from 'path';
import rimraf from 'rimraf';
import { getPackageManager } from 'webpack-cli/lib/utils/get-package-manager';
import { getPackageManager } from 'webpack-cli';
import addonGenerator from '../src/addon-generator';

// TODO: enable after jest release
Expand Down
4 changes: 2 additions & 2 deletions packages/generators/src/addon-generator.ts
@@ -1,9 +1,9 @@
import logger from 'webpack-cli/lib/utils/logger';
import { logger } from 'webpack-cli';
import fs from 'fs';
import path from 'path';
import Generator from 'yeoman-generator';
import { generatorCopy, generatorCopyTpl } from '@webpack-cli/utils';
import { getPackageManager } from 'webpack-cli/lib/utils/get-package-manager';
import { getPackageManager } from 'webpack-cli';

/**
* Creates a Yeoman Generator that generates a project conforming
Expand Down
3 changes: 1 addition & 2 deletions packages/generators/src/init-generator.ts
@@ -1,8 +1,7 @@
import { blue, green, bold } from 'colorette';
import logger from 'webpack-cli/lib/utils/logger';
import { logger, getPackageManager } from 'webpack-cli';
import logSymbols from 'log-symbols';
import path from 'path';
import { getPackageManager } from 'webpack-cli/lib/utils/get-package-manager';
import { Confirm, Input, List } from '@webpack-cli/webpack-scaffold';

import {
Expand Down
4 changes: 2 additions & 2 deletions packages/info/src/index.ts
@@ -1,6 +1,6 @@
import envinfo from 'envinfo';
import logger from 'webpack-cli/lib/utils/logger';
import { commands } from 'webpack-cli/lib/utils/cli-flags';
import { logger } from 'webpack-cli';
import { commands } from 'webpack-cli';
import WebpackCLI from 'webpack-cli';

interface Information {
Expand Down
2 changes: 1 addition & 1 deletion packages/migrate/src/index.ts
Expand Up @@ -2,7 +2,7 @@ import { green, red } from 'colorette';
import { Change, diffLines } from 'diff';
import fs from 'fs';
import inquirer from 'inquirer';
import logger from 'webpack-cli/lib/utils/logger';
import { logger } from 'webpack-cli';
import Listr from 'listr';
import pLazy = require('p-lazy');
import path from 'path';
Expand Down
@@ -1,6 +1,6 @@
import { red, underline } from 'colorette';

import logger from 'webpack-cli/lib/utils/logger';
import { logger } from 'webpack-cli';

import { findPluginsByName, isType, safeTraverse } from '@webpack-cli/utils';

Expand Down
2 changes: 1 addition & 1 deletion packages/serve/src/parseArgs.ts
@@ -1,4 +1,4 @@
import logger from 'webpack-cli/lib/utils/logger';
import { logger } from 'webpack-cli';

type WebpackCLIType = {
getCoreFlags: Function;
Expand Down
6 changes: 2 additions & 4 deletions packages/utils/__tests__/global-packages-path.test.ts
@@ -1,10 +1,8 @@
'use strict';
jest.setMock('webpack-cli/lib/utils/get-package-manager', {
getPackageManager: jest.fn(),
});
jest.setMock('webpack-cli/lib/utils/get-package-manager', jest.fn());

import { getPathToGlobalPackages } from '../lib/global-packages-path';
import { getPackageManager } from 'webpack-cli/lib/utils/get-package-manager';
import { getPackageManager } from 'webpack-cli';
jest.mock('execa');
jest.mock('cross-spawn');
const globalModulesNpmValue = 'test-npm';
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/src/global-packages-path.ts
@@ -1,6 +1,6 @@
import spawn from 'cross-spawn';
import path from 'path';
import { getPackageManager } from 'webpack-cli/lib/utils/get-package-manager';
import { getPackageManager } from 'webpack-cli';

/**
*
Expand Down
4 changes: 2 additions & 2 deletions packages/utils/src/modify-config-helper.ts
@@ -1,11 +1,11 @@
import { green } from 'colorette';
import fs from 'fs';
import logger from 'webpack-cli/lib/utils/logger';
import { logger } from 'webpack-cli';
import path from 'path';
import yeoman from 'yeoman-environment';
import Generator from 'yeoman-generator';
import { runTransform } from './scaffold';
import { getPackageManager } from 'webpack-cli/lib/utils/get-package-manager';
import { getPackageManager } from 'webpack-cli';

export interface Config extends Object {
item?: {
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/src/recursive-parser.ts
@@ -1,7 +1,7 @@
import { parseTopScope, findRootNodesByName, addProperty, removeProperty, parseMerge, safeTraverse } from './ast-utils';
import { JSCodeshift, Node, valueType } from './types/NodePath';

import logger from 'webpack-cli/lib/utils/logger';
import { logger } from 'webpack-cli';

export function recursiveTransform(j: JSCodeshift, ast: Node, key: string, value: valueType, action: string): boolean | Node {
if (key === 'topScope') {
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/src/resolve-packages.ts
@@ -1,5 +1,5 @@
import { bold } from 'colorette';
import logger from 'webpack-cli/lib/utils/logger';
import { logger } from 'webpack-cli';
import path from 'path';
import { modifyHelperUtil } from './modify-config-helper';
import { getPathToGlobalPackages } from './global-packages-path';
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/src/run-prettier.ts
@@ -1,5 +1,5 @@
import fs from 'fs';
import logger from 'webpack-cli/lib/utils/logger';
import { logger } from 'webpack-cli';

/**
*
Expand Down
4 changes: 2 additions & 2 deletions packages/utils/src/scaffold.ts
@@ -1,9 +1,9 @@
import { green } from 'colorette';
import j from 'jscodeshift';
import logger from 'webpack-cli/lib/utils/logger';
import { logger } from 'webpack-cli';
import pEachSeries = require('p-each-series');
import path from 'path';
import { getPackageManager } from 'webpack-cli/lib/utils/get-package-manager';
import { getPackageManager } from 'webpack-cli';
import { findProjectRoot } from './path-utils';
import { Error } from './types';
import { Config, TransformConfig } from './types';
Expand Down
2 changes: 1 addition & 1 deletion packages/utils/src/spawn-child.ts
Expand Up @@ -2,7 +2,7 @@ import path from 'path';
import fs from 'fs';
import { ExecaSyncReturnValue, sync } from 'execa';
import { getPathToGlobalPackages } from './global-packages-path';
import { getPackageManager } from 'webpack-cli/lib/utils/get-package-manager';
import { getPackageManager } from 'webpack-cli';

/**
*
Expand Down
11 changes: 11 additions & 0 deletions packages/webpack-cli/lib/index.js
@@ -0,0 +1,11 @@
const WebpackCLI = require('./webpack-cli');
const { commands } = require('./utils/cli-flags');
const logger = require('./utils/logger');
const getPackageManager = require('./utils/get-package-manager');

module.exports = WebpackCLI;

// export additional utils used by other packages
module.exports.logger = logger;
module.exports.commands = commands;
module.exports.getPackageManager = getPackageManager;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's export this under util, like webpackCli.util.logger?

Expand Up @@ -9,7 +9,7 @@ const syncMock = jest.fn(() => {
jest.setMock('execa', {
sync: syncMock,
});
const { getPackageManager } = require('../get-package-manager');
const getPackageManager = require('../get-package-manager');

jest.mock('cross-spawn');
const globalModulesNpmValue = 'test-npm';
Expand Down
Expand Up @@ -16,11 +16,9 @@ jest.setMock('../package-exists', {
packageExists: jest.fn(),
});

jest.setMock('../get-package-manager', {
getPackageManager: jest.fn(),
});
jest.setMock('../get-package-manager', jest.fn());

const { getPackageManager } = require('../get-package-manager');
const getPackageManager = require('../get-package-manager');
const { packageExists } = require('../package-exists');
const { promptInstallation } = require('../prompt-installation');
const { runCommand } = require('../run-command');
Expand Down
4 changes: 1 addition & 3 deletions packages/webpack-cli/lib/utils/get-package-manager.js
Expand Up @@ -30,6 +30,4 @@ function getPackageManager() {
return 'npm';
}

module.exports = {
getPackageManager,
};
module.exports = getPackageManager;
2 changes: 1 addition & 1 deletion packages/webpack-cli/lib/utils/prompt-installation.js
@@ -1,7 +1,7 @@
const { prompt } = require('enquirer');
const { green } = require('colorette');
const { runCommand } = require('./run-command');
const { getPackageManager } = require('./get-package-manager');
const getPackageManager = require('./get-package-manager');
const { packageExists } = require('./package-exists');

/**
Expand Down
2 changes: 1 addition & 1 deletion packages/webpack-cli/package.json
Expand Up @@ -10,7 +10,7 @@
"bin": {
"webpack-cli": "./bin/cli.js"
},
"main": "./lib/webpack-cli.js",
"main": "./lib/index.js",
"engines": {
"node": ">=10.13.0"
},
Expand Down