New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor code #2048
Refactor code #2048
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2048 +/- ##
==========================================
+ Coverage 68.49% 68.56% +0.07%
==========================================
Files 75 74 -1
Lines 2390 2386 -4
Branches 496 506 +10
==========================================
- Hits 1637 1636 -1
+ Misses 753 750 -3
Continue to review full report at Codecov.
|
need fix CI |
Yep, on it |
af04a6d
to
3627892
Compare
Fixed:
|
a50de34
to
80c4432
Compare
Need rerun tests after #2042 |
0bb6159
to
bf58b58
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets fix CI
bf58b58
to
031e7b2
Compare
031e7b2
to
e3f0554
Compare
/cc @anshumanv something wrong with rebase |
I will fix skipping test in future |
I don't understand what the hell with color on CI |
Just pass --no-color in test to avoid it. |
We should disable colors for tests by default, and enable them only when we need to test it |
What kind of change does this PR introduce?
refactoring
If relevant, did you update the documentation?
No need
Summary
refactor
Does this PR introduce a breaking change?
No
Other information
WIP