Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor code #2048

Merged
merged 17 commits into from Nov 11, 2020
Merged

Refactor code #2048

merged 17 commits into from Nov 11, 2020

Conversation

alexander-akait
Copy link
Member

What kind of change does this PR introduce?

refactoring

If relevant, did you update the documentation?

No need

Summary

refactor

Does this PR introduce a breaking change?

No

Other information

WIP

@codecov
Copy link

codecov bot commented Nov 5, 2020

Codecov Report

Merging #2048 (6107f3f) into master (363f120) will increase coverage by 0.07%.
The diff coverage is 91.02%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2048      +/-   ##
==========================================
+ Coverage   68.49%   68.56%   +0.07%     
==========================================
  Files          75       74       -1     
  Lines        2390     2386       -4     
  Branches      496      506      +10     
==========================================
- Hits         1637     1636       -1     
+ Misses        753      750       -3     
Impacted Files Coverage Δ
packages/utils/src/global-packages-path.ts 72.72% <50.00%> (ø)
packages/webpack-cli/lib/webpack-cli.js 93.20% <66.66%> (-0.31%) ⬇️
packages/webpack-cli/lib/utils/resolve-command.js 68.42% <77.77%> (-3.01%) ⬇️
packages/webpack-cli/lib/groups/runVersion.js 92.50% <90.62%> (+5.83%) ⬆️
packages/webpack-cli/lib/groups/runHelp.js 98.64% <98.55%> (-1.36%) ⬇️
packages/webpack-cli/lib/bootstrap.js 100.00% <100.00%> (ø)
packages/webpack-cli/lib/utils/arg-parser.js 93.40% <100.00%> (-0.08%) ⬇️
packages/webpack-cli/lib/utils/cli-flags.js 100.00% <100.00%> (ø)
packages/webpack-cli/lib/utils/to-kebab-case.js 100.00% <100.00%> (ø)
packages/webpack-cli/lib/utils/logger.js 88.88% <0.00%> (-11.12%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4289c0...6107f3f. Read the comment docs.

@anshumanv
Copy link
Member

need fix CI

@alexander-akait
Copy link
Member Author

Yep, on it

@alexander-akait
Copy link
Member Author

Fixed:

  • extra lines in output for help/version
  • exit code with some errors
  • remove unused code
  • refactor some parts
  • reduce initial run

@alexander-akait
Copy link
Member Author

Need rerun tests after #2042

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets fix CI

@anshumanv anshumanv force-pushed the refactor-code branch 2 times, most recently from bf58b58 to 031e7b2 Compare November 10, 2020 12:18
@alexander-akait
Copy link
Member Author

/cc @anshumanv something wrong with rebase

anshumanv
anshumanv previously approved these changes Nov 11, 2020
@alexander-akait
Copy link
Member Author

I will fix skipping test in future

@alexander-akait
Copy link
Member Author

I don't understand what the hell with color on CI

@snitin315
Copy link
Member

Just pass --no-color in test to avoid it.

@alexander-akait
Copy link
Member Author

We should disable colors for tests by default, and enable them only when we need to test it

@alexander-akait alexander-akait merged commit f6f4585 into master Nov 11, 2020
@alexander-akait alexander-akait deleted the refactor-code branch November 11, 2020 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants