Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove default value for devtool #2053

Merged
merged 1 commit into from Nov 7, 2020

Conversation

anshumanv
Copy link
Member

What kind of change does this PR introduce?
fix

Did you add tests for your changes?
NA

If relevant, did you update the documentation?
NA

Summary
Remove the default value of some flags since they are invalid and not used in most cases.

Does this PR introduce a breaking change?
No

Other information

@codecov
Copy link

codecov bot commented Nov 6, 2020

Codecov Report

Merging #2053 (428194d) into master (1e0b0b4) will decrease coverage by 0.50%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2053      +/-   ##
==========================================
- Coverage   68.81%   68.31%   -0.51%     
==========================================
  Files          82       77       -5     
  Lines        2437     2408      -29     
  Branches      494      496       +2     
==========================================
- Hits         1677     1645      -32     
- Misses        760      763       +3     
Impacted Files Coverage Δ
packages/webpack-cli/lib/utils/cli-flags.js 100.00% <ø> (ø)
packages/webpack-cli/lib/webpack-cli.js 90.19% <0.00%> (-3.93%) ⬇️
packages/webpack-cli/lib/utils/arg-parser.js 93.47% <0.00%> (ø)
packages/webpack-cli/lib/groups/resolveStats.js
packages/webpack-cli/lib/groups/resolveMode.js
packages/webpack-cli/lib/groups/basicResolver.js
packages/webpack-cli/lib/groups/resolveOutput.js
packages/webpack-cli/lib/groups/resolveAdvanced.js

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e0b0b4...428194d. Read the comment docs.

Comment on lines 94 to 96
negative: true,
defaultValue: true,
description: 'Enable/Disable colors on console',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the color needs some more fixes, I'm removing it in
#2042 (comment)

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove it for devtool only here.

@webpack-bot
Copy link

@anshumanv Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@snitin315 Please review the new changes.

@snitin315 snitin315 marked this pull request as ready for review November 7, 2020 05:52
@snitin315 snitin315 requested a review from a team as a code owner November 7, 2020 05:52
@snitin315 snitin315 changed the title fix: remove default value for flags fix: remove default value for devtool Nov 7, 2020
@alexander-akait alexander-akait merged commit 6618243 into webpack:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants