New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: respect stats
from the config for webpack@4
#2098
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
0aca42d
fix: respect `stats` from the config for webpack@4
alexander-akait aaec2cf
refactor: fix typo
evilebottnawi d7b393a
fix: error case
alexander-akait 6fb4936
fix: ci
snitin315 86a6b11
fix: ci
snitin315 f934054
tests: fix
snitin315 File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
module.exports = [ | ||
{ | ||
watch: true, | ||
stats: 'none', | ||
}, | ||
{ | ||
watch: true, | ||
stats: 'none', | ||
}, | ||
]; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
console.log('TEST'); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
'use strict'; | ||
|
||
const { runWatch, isWebpack5 } = require('../../utils/test-utils'); | ||
|
||
describe('stats and watch', () => { | ||
it('should not log stats with the "none" value from the configuration', async () => { | ||
const { stderr, stdout } = await runWatch(__dirname, ['-c', './webpack.config.js']); | ||
|
||
expect(stdout).toContain('[webpack-cli] Compilation starting...'); | ||
expect(stdout).toContain('[webpack-cli] Compilation finished'); | ||
expect(stdout).toContain('[webpack-cli] watching files for updates...'); | ||
expect(stderr).toBeFalsy(); | ||
}); | ||
|
||
it('should not log stats with the "none" value from the configuration and multi compiler mode', async () => { | ||
const { stderr, stdout } = await runWatch(__dirname, ['-c', './multi-webpack.config.js']); | ||
|
||
expect(stdout).toContain('[webpack-cli] Compilation starting...'); | ||
expect(stdout).toContain('[webpack-cli] Compilation finished'); | ||
expect(stdout).toContain('[webpack-cli] watching files for updates...'); | ||
expect(stderr).toBeFalsy(); | ||
}); | ||
|
||
it('should log stats with the "normal" value in arguments', async () => { | ||
const { stderr, stdout } = await runWatch(__dirname, ['-c', './webpack.config.js', '--stats', 'normal']); | ||
|
||
const output = isWebpack5 ? 'successfully' : 'main.js'; | ||
|
||
expect(stdout).toContain('[webpack-cli] Compilation starting...'); | ||
expect(stdout).toContain('[webpack-cli] Compilation finished'); | ||
expect(stdout).toContain(output); | ||
expect(stdout).toContain('[webpack-cli] watching files for updates...'); | ||
expect(stderr).toBeFalsy(); | ||
}); | ||
}); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
module.exports = { | ||
watch: true, | ||
stats: 'none', | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When we use
stats: 'none'
we have empty string, so no need to log empty string