Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add serve smoketest #2502

Merged
merged 2 commits into from Mar 15, 2021
Merged

test: add serve smoketest #2502

merged 2 commits into from Mar 15, 2021

Conversation

rishabh3112
Copy link
Member

What kind of change does this PR introduce?
test

Did you add tests for your changes?
Yup

If relevant, did you update the documentation?

Summary
Part of #2493

Does this PR introduce a breaking change?
No

Other information
No

@rishabh3112 rishabh3112 requested a review from a team as a code owner March 15, 2021 12:49
@codecov
Copy link

codecov bot commented Mar 15, 2021

Codecov Report

Merging #2502 (2eb29ab) into master (a78ccfe) will increase coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2502      +/-   ##
==========================================
+ Coverage   71.86%   71.91%   +0.04%     
==========================================
  Files          46       46              
  Lines        2186     2186              
  Branches      583      583              
==========================================
+ Hits         1571     1572       +1     
+ Misses        615      614       -1     
Impacted Files Coverage Δ
packages/webpack-cli/bin/cli.js 55.00% <0.00%> (+5.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a78ccfe...2eb29ab. Read the comment docs.

@rishabh3112
Copy link
Member Author

/cc @webpack/cli-team needs review

@anshumanv anshumanv merged commit f010690 into master Mar 15, 2021
@anshumanv anshumanv deleted the test/serve-smoketest branch March 15, 2021 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants