New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: leverage helpers for smoketests #2519
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2519 +/- ##
===========================================
+ Coverage 72.60% 90.82% +18.21%
===========================================
Files 46 29 -17
Lines 2234 1449 -785
Branches 603 411 -192
===========================================
- Hits 1622 1316 -306
+ Misses 612 133 -479
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a suggestion.
@jamesgeorge007 Thanks for your update. I labeled the Pull Request so reviewers will review it again. @rishabh3112 Please review the new changes. |
What kind of change does this PR introduce?
refactoring
Did you add tests for your changes?
Update smoke tests
If relevant, did you update the documentation?
Nope
Summary
This PR aims at refactoring the smoke test suite by introducing helpers.
#2493
Does this PR introduce a breaking change?
Nope
Other information
N/A