Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: leverage helpers for smoketests #2519

Merged
merged 3 commits into from Mar 19, 2021
Merged

Conversation

jamesgeorge007
Copy link
Member

@jamesgeorge007 jamesgeorge007 commented Mar 19, 2021

What kind of change does this PR introduce?
refactoring

Did you add tests for your changes?
Update smoke tests

If relevant, did you update the documentation?
Nope

Summary
This PR aims at refactoring the smoke test suite by introducing helpers.
#2493

Does this PR introduce a breaking change?
Nope

Other information
N/A

@codecov
Copy link

codecov bot commented Mar 19, 2021

Codecov Report

Merging #2519 (107a85d) into master (4fccb73) will increase coverage by 18.21%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           master    #2519       +/-   ##
===========================================
+ Coverage   72.60%   90.82%   +18.21%     
===========================================
  Files          46       29       -17     
  Lines        2234     1449      -785     
  Branches      603      411      -192     
===========================================
- Hits         1622     1316      -306     
+ Misses        612      133      -479     
Impacted Files Coverage Δ
packages/generators/src/utils/scaffold-utils.ts 52.38% <0.00%> (-42.86%) ⬇️
packages/webpack-cli/lib/bootstrap.js 80.00% <0.00%> (-20.00%) ⬇️
...kages/webpack-cli/lib/utils/get-package-manager.js 57.69% <0.00%> (-3.85%) ⬇️
packages/generators/src/types/index.ts 100.00% <0.00%> (ø)
packages/generators/src/utils/recursive-parser.ts
packages/generators/src/utils/index.ts
packages/generators/init-template/package.json.js
packages/generators/src/utils/validate.ts
...ckages/generators/src/utils/npm-packages-exists.ts
packages/generators/src/utils/run-prettier.ts
... and 19 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4fccb73...107a85d. Read the comment docs.

snitin315
snitin315 previously approved these changes Mar 19, 2021
Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a suggestion.

smoketests/helpers.js Outdated Show resolved Hide resolved
smoketests/helpers.js Outdated Show resolved Hide resolved
@webpack-bot
Copy link

@jamesgeorge007 Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@rishabh3112 Please review the new changes.

@rishabh3112 rishabh3112 merged commit f1a5f08 into master Mar 19, 2021
@rishabh3112 rishabh3112 deleted the refactor/smoketests branch March 19, 2021 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants