New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: config tests #2939
refactor: config tests #2939
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## master #2939 +/- ##
=======================================
Coverage 95.13% 95.13%
=======================================
Files 31 31
Lines 1684 1684
Branches 483 483
=======================================
Hits 1602 1602
Misses 82 82 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ready to merge?
Still there are a lot of tests with bad descriptions 😞. If this is needs to be merged now, I can open a separate pull request later to address them. |
You can continue work here 👍 |
* fix: absent config test * chore: basic config description * chore: update default js config test * chore: update dot webpack config test * chore: update dot webpack webpackfile test * chore: fix description of cjs config * chore: update mjs config * chore: default config with mode * chore: fix empty test * chore: update empty array * chore: update empty function descriptions * chore: update empty promise * chore: update config array error * chore: update no config * chore: update invalid path file * chore: update config error test * chore: fix funtional config test * chore: invalid export * chore: update multiple config test * chore: update config test * chore: update no code test * chore: update no config array test * chore: update no config object test
What kind of change does this PR introduce?
refactor
Did you add tests for your changes?
Yup
If relevant, did you update the documentation?
Not needed,
Summary
There are various grammatical mistakes as well as non standard descriptions.
Some cases also have redundant files.
Does this PR introduce a breaking change?
Nope
Other information
Discussed in #2930