New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create-webpack-app #3036
base: master
Are you sure you want to change the base?
feat: create-webpack-app #3036
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3036 +/- ##
==========================================
+ Coverage 90.98% 91.50% +0.51%
==========================================
Files 23 23
Lines 1731 1719 -12
Branches 519 519
==========================================
- Hits 1575 1573 -2
+ Misses 156 146 -10
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add smoke test? Yes, it will be failed here, but I am do first release after this and we will look at tests
Yup sure, will do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the point of naming an internal command/tool that is invoked through webpack-cli to something that indicates being a standalone tool..
@evenstensberg Earlier I described the problem, shorty - when you use |
@alexander-akait should we wait for #2862 to get merged here? |
Reviewed 👍 |
Thanks! |
As #2862 is merged, I will continue working on this now! |
[Note for self] TODO: Move new templates into create webpack app repo. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rishabh3112 could you pick up the work on this again?
@evenstensberg there roadmap for the same currently? If not lets finalize that first. This PR is anyway very old now. |
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information