Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(md): formats md before committing #851

Merged
merged 3 commits into from May 24, 2019
Merged

feat(md): formats md before committing #851

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
437b5d5
feat(format): formattes markdowns before commit
pranshuchittora Apr 23, 2019
5dc5e75
feat(prettier): adds prettier and formattes markdowns
pranshuchittora Apr 23, 2019
b9f8339
Merge branch 'master' of github.com:webpack/webpack-cli into markdown…
pranshuchittora May 24, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
7 changes: 3 additions & 4 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions package.json
View file
Open in desktop
Expand Up @@ -54,6 +54,10 @@
}
},
"lint-staged": {
"*.md": [
"prettier --parser markdown --write",
"git add"
],
"{packages,bin}/**/!(__testfixtures__)/**.js": [
"eslint --fix",
"git add"
Expand Down Expand Up @@ -124,6 +128,7 @@
"import-local": "^2.0.0",
"interpret": "^1.1.0",
"loader-utils": "^1.1.0",
"prettier": "^1.17.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pranshuchittora was there a reason prettier needed to be added to dependencies instead of devDependencies?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix submitted as #968.

"supports-color": "^5.5.0",
"v8-compile-cache": "^2.0.2",
"yargs": "^12.0.5"
Expand Down