New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ci): add node 12 #872
Merged
Merged
Changes from 2 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
62e98aa
chore(ci): add node 12
misterdev 6ca6235
chore(ci): add stable and improve azure config
misterdev df4928b
chore(azure pipeline): fix configuration
misterdev ddf5587
chore(azure): revert npm ci
misterdev bd560a8
Merge branch 'add-node12-travis' of https://github.com/misterdev/webp…
misterdev 6f0bbc2
chore(azure): revert changes to npm installation
misterdev 8f02bb3
chore(azure): change to npm ci
misterdev 8620755
chore(azure): try boostrap:ci script
misterdev c16d0ed
chore(azure): revert to npm install & refactor
misterdev a374558
chore(travis): install node 12
misterdev b26abd1
chore(travis): remove "stable" in favour of version
misterdev 89b307a
Merge branch 'master' into add-node12-travis
misterdev 2ae3a33
chore(ci): remove node 6 from travis & azure
misterdev 73592eb
chore(bundlesize): update to 1.17.2
misterdev File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
npm ci is probably better, runs fresh install with lockfile
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's true, I'm just investigating on what broke the Azure CI :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems that using
npm ciinstead ofnpm installbreaks on "macOS node-6"It fails with
sh: rimraf: command not foundwhile executingnpm run bootstrapI'm keeping the old
npm install. Any idea on how to fix this is welcome :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better always update npm to latest before use npm commands, npm is very buggy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are right, on Mac OS it doesn't update npm to the latest version.
But the fix suggested here doesn't work on Linux
I'm going to investigate in the next days :)