Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: code of conduct #873

Merged
merged 3 commits into from May 3, 2019
Merged

docs: code of conduct #873

merged 3 commits into from May 3, 2019

Conversation

ematipico
Copy link
Contributor

What kind of change does this PR introduce?
No
Did you add tests for your changes?
No

If relevant, did you update the documentation?
No

Summary
Added a simple template for code of conduct. Copied from webpack.js.org

Does this PR introduce a breaking change?

No

Other information

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we move it to .github? :)

Also, file name has a typo, please see.

@ematipico
Copy link
Contributor Author

ematipico commented Apr 30, 2019

Github scans the CODE_OF_CONDUCT.md file inside the root folder of the project.

Edit: Github also suggests different template but webpack is under the OpenJS foundation (former JS Foundation).

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Github scans the CODE_OF_CONDUCT.md file inside the root folder of the project

Correct, proly we should move it to project root in js.org too.

@anshumanv
Copy link
Member

anshumanv commented Apr 30, 2019

Apparently, it scans .github too - https://help.github.com/en/articles/adding-a-code-of-conduct-to-your-project#adding-a-code-of-conduct-manually 😄 fine either way ✨

@ematipico
Copy link
Contributor Author

I think it's more visible if we left it in the project root. What do you think? It's not a .github thing, it's a project thing.

@anshumanv
Copy link
Member

Yeah lgtm, you think linking it in the README will prove to be helpful? 🤔

@ematipico
Copy link
Contributor Author

Yeah lgtm, you think linking it in the README will prove to be helpful?

@anshumanv Maybe from the contribution readme file?

Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have left some of suggestions :)

CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
CODE_OF_CONDUCT.md Outdated Show resolved Hide resolved
@webpack-bot
Copy link

@ematipico Thanks for your update.

I labeled the Pull Request so reviewers will review it again.

@rishabh3112 Please review the new changes.

Copy link
Member

@rishabh3112 rishabh3112 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, lgtm 🙂

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@ematipico ematipico merged commit 7883871 into master May 3, 2019
@anshumanv anshumanv deleted the code-of-conduct branch August 4, 2020 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants