Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chore): Added type definitions for the data returned by envinfo #921

Merged
merged 1 commit into from Jun 5, 2019

Conversation

jamesgeorge007
Copy link
Member

@jamesgeorge007 jamesgeorge007 commented Jun 5, 2019

What kind of change does this PR introduce?
refactoring

Did you add tests for your changes?
Nope

If relevant, did you update the documentation?
Nope

Summary
Added type definitions for what envinfo returns.

Does this PR introduce a breaking change?
Nope

@jamesgeorge007
Copy link
Member Author

cc @evenstensberg

Copy link
Member

@anshumanv anshumanv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@webpack-bot
Copy link

Thank you for your pull request! The most important CI builds succeeded, we’ll review the pull request soon.

@ematipico ematipico merged commit fe80517 into webpack:master Jun 5, 2019
@ematipico
Copy link
Contributor

Thanks!

@jamesgeorge007 jamesgeorge007 deleted the feat/add-types branch June 25, 2019 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants