Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: headers support function 'Last-Modified': () => new Date() (#749) #890

Closed
wants to merge 1 commit into from
Closed

Conversation

Nhjkl
Copy link

@Nhjkl Nhjkl commented Apr 28, 2021

#749 I think we can solve this problem in this way

webpackDevMiddleware(compiler, {
  headers: {
    'Last-Modified': () => new Date()
  }
})

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think better to allow headers will be function

@Nhjkl
Copy link
Author

Nhjkl commented Apr 28, 2021

Good idea

Can it fit into the schedule

@alexander-akait
Copy link
Member

Yes, feel free to improve, even more, maybe we can send req/res/etc as arguments, so you can create more complex things

@Nhjkl
Copy link
Author

Nhjkl commented Apr 28, 2021

Agree with.

Looking forward to the update

@Nhjkl
Copy link
Author

Nhjkl commented Apr 28, 2021

I don't know much English, and this is my first time to submit PR.

Do you mean I will continue to improve, or you will improve yourself

@alexander-akait
Copy link
Member

Do you mean I will continue to improve, or you will improve yourself

You can continue improve, it is easy to implement

@Nhjkl
Copy link
Author

Nhjkl commented Apr 28, 2021

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants