Use built version os sockjs-client (#1148)

`webpack-dev-server` bundles `sockjs-client` from source. `sockjs-client` sources assume a node environment however, and will fail to run if `global` is not available. By bundling `sockjs-client` from source, the node environment requirement from `sockjs-client` will also be required of the app being served and thus it is not possible to have `node.global = false` in the user app being bundled. This fix uses the built `sockjs-client` instead of the sources. Fix #1147
webpack · Oct 16, 2017 · 06df2f4 · 06df2f4 · slate71 · Oct 22, 2017
1 parent 32412bb
commit 06df2f4
Show file tree

Hide file tree

Showing 6 changed files with 31 additions and 2 deletions.
diff --git a/client/socket.js b/client/socket.js
@@ -1,6 +1,6 @@
 'use strict';
 
-const SockJS = require('sockjs-client');
+const SockJS = require('sockjs-client/dist/sockjs');
 
 let retries = 0;
 let sock = null;

diff --git a/examples/node-false/README.md b/examples/node-false/README.md
@@ -0,0 +1,9 @@
+# CLI - node false
+
+```shell
+node ../../bin/webpack-dev-server.js --open
+```
+
+## What should happen
+
+In the app you should see "It's working."
diff --git a/examples/node-false/app.js b/examples/node-false/app.js
@@ -0,0 +1,3 @@
+'use strict';
+
+document.write("It's working.");
diff --git a/examples/node-false/index.html b/examples/node-false/index.html
@@ -0,0 +1,9 @@
+<!DOCTYPE html>
+<html>
+	<head>
+		<script src="bundle.js" type="text/javascript" charset="utf-8"></script>
+	</head>
+	<body>
+		<h1>Example: CLI - node false</h1>
+	</body>
+</html>
diff --git a/examples/node-false/webpack.config.js b/examples/node-false/webpack.config.js
@@ -0,0 +1,7 @@
+'use strict';
+
+module.exports = {
+  context: __dirname,
+  entry: './app.js',
+  node: false
+};
diff --git a/test/fixtures/simple-config/webpack.config.js b/test/fixtures/simple-config/webpack.config.js
@@ -6,5 +6,6 @@ module.exports = {
   output: {
     filename: 'bundle.js',
     path: '/'
-  }
+  },
+  node: false
 };