feat(progess): emit progress-update (#2498)

closes: #1666
webpack · Apr 3, 2020 · 4808abd · 4808abd
1 parent adeb92e
commit 4808abd
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 5 deletions.
diff --git a/lib/Server.js b/lib/Server.js
@@ -155,6 +155,10 @@ class Server {
       }
 
       this.sockWrite(this.sockets, 'progress-update', { percent, msg });
+
+      if (this.listeningApp) {
+        this.listeningApp.emit('progress-update', { percent, msg });
+      }
     }).apply(this.compiler);
   }
 

diff --git a/lib/servers/WebsocketServer.js b/lib/servers/WebsocketServer.js
@@ -31,11 +31,13 @@ module.exports = class WebsocketServer extends BaseServer {
     const noop = () => {};
 
     setInterval(() => {
-      this.wsServer.clients.forEach((ws) => {
-        if (ws.isAlive === false) return ws.terminate();
+      this.wsServer.clients.forEach((socket) => {
+        if (socket.isAlive === false) {
+          return socket.terminate();
+        }
 
-        ws.isAlive = false;
-        ws.ping(noop);
+        socket.isAlive = false;
+        socket.ping(noop);
       });
     }, this.server.heartbeatInterval);
   }

diff --git a/test/server/progress-option.test.js b/test/server/progress-option.test.js
@@ -46,7 +46,13 @@ describe('progress', () => {
       });
 
       compiler.run(() => {});
-      server.listen(port, 'localhost');
+      const app = server.listen(port, 'localhost');
+
+      app.on('progress-update', ({ percent, msg }) => {
+        expect(percent).toBeGreaterThanOrEqual(0);
+        expect(percent).toBeLessThanOrEqual(100);
+        expect(typeof msg).toEqual('string');
+      });
     });
   });
 });