feat(server): removed BaseServer inheritance requirement

webpack · May 30, 2019 · 680d73f · 680d73f
1 parent aa6f615
commit 680d73f
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 22 deletions.
diff --git a/lib/Server.js b/lib/Server.js
@@ -31,7 +31,6 @@ const createDomain = require('./utils/createDomain');
 const runBonjour = require('./utils/runBonjour');
 const routes = require('./utils/routes');
 const schema = require('./options.json');
-const BaseServer = require('./servers/BaseServer');
 
 // Workaround for node ^8.6.0, ^9.0.0
 // DEFAULT_ECDH_CURVE is default to prime256v1 in these version
@@ -97,13 +96,6 @@ class Server {
       serverImplFound = false;
     }
 
-    if (
-      serverImplFound &&
-      !(ServerImplementation.prototype instanceof BaseServer)
-    ) {
-      serverImplFound = false;
-    }
-
     if (!serverImplFound) {
       throw new Error(
         "serverMode must be a string denoting a default implementation (eg. 'sockjs'), a full path to " +

diff --git a/test/ServerMode.test.js b/test/ServerMode.test.js
@@ -117,20 +117,6 @@ describe('serverMode', () => {
     });
   });
 
-  describe('supplying unimplemented BaseServer', () => {
-    it('should throw an error', () => {
-      expect(() => {
-        server = testServer.start(
-          config,
-          {
-            serverMode: BaseServer,
-          },
-          () => {}
-        );
-      }).toThrow(/serverMode must be a string/);
-    });
-  });
-
   describe('supplying nonexistent path', () => {
     it('should throw an error', () => {
       expect(() => {